Re: [PATCH] ARM: omap5: build opp4xxx_data.c

Santosh Shilimkar
2013-06-25T23:28:06Z

On Tuesday 25 June 2013 07:02 PM, Nishanth Menon wrote:
> On 18:43-20130625, Santosh Shilimkar wrote:
>> On Tuesday 25 June 2013 06:36 PM, Nishanth Menon wrote:
>>> On 16:59-20130625, Santosh Shilimkar wrote:
>>>> On Tuesday 25 June 2013 04:56 PM, Kevin Hilman wrote:
>>>>> Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
>>>>>
>>>>>> On Tuesday 25 June 2013 04:17 PM, Nishanth Menon wrote:
>>>>>>> On Tue, Jun 25, 2013 at 3:12 PM, Santosh Shilimkar
>>>>>>> <santosh.shilimkar@ti.com> wrote:
>>>>>>>>
>>>>>>>> Well having voltage data in voltage domain was not my decision ;-)
>>>>>>>> Instead of creating another set of dummy data, I just used what
>>>>>>>> is out there(OMAP4) with clear comment that data needs to be updated.
>>>>>>>> I don't see any problem in this considering we have devices booting
>>>>>>>> and working nicely for OMAP5
>>>>>>> I really wish the OMAP5 devices(the latest ones from Fab) I have would
>>>>>>> like to function at OMAP4 configurations! Unfortunately the devices
>>>>>>> tend to follow the data manual for OMAP5.
>>>>>>> *if* there is no need for it to boot, I suggest removing it.
>>>>>>>
>>>>>> I don't understand you. For OMAP5, that data without voltage
>>>>>> controller support doesn't do anything bad. Since there was some
>>>>>> dependency of voltage domain association whit PD's, I have to keep
>>>>>> that. I never claimed that OMAP4 settings would work for OMAP5
>>>>>> in absolute terms.
>>>>>>
>>>>>> Feel free to post a patch with right data which you seems to have.
>>>>>> I don't mind you removing that data as long as the device
>>>>>> continues to boot. Patch welcome.
>>>>>
>>>>> Thanks to Rajendra's cleanup, I don't think we need dummy data anymore:
>>>>>
>>>>> http://marc.info/?l=linux-omap&m=137147503827947&w=2
>>>>>
>>>>> That series is queued for v3.11.
>>>>>
>>>> I knew the series but wasn't sure about it getting queued up
>>>> for 3.11. Nice to see the dependency is getting removed.
>>>
>>> Anyways, I tried booting up a kernel built on linux-next-20130625
>>> with omap2plus_defconfig and [1] on OMAP5uEVM and all I see is:
>>> Importing environment from mmc0 ...
>>> reading //zImage
>>> 4030024 bytes read in 198 ms (19.4 MiB/s)
>>> reading //omap5-uevm.dtb
>>> 17729 bytes read in 16 ms (1.1 MiB/s)
>>> [..]
>>> ## Flattened Device Tree blob at 80f80000
>>> Booting using the fdt blob at 0x80f80000
>>> Using Device Tree in place at 80f80000, end 80f87540
>>>
>>> Starting kernel ...
>>>
>>> If someone can point me to a functional base, it'd be nice, or if there
>>> is a known pending fix, it'd be better..
>>> Taking http://marc.info/?l=linux-omap&m=136984555408516&w=2 and rebasing
>>> on linux next tag resulted practically in NOP.
>>>
>> As mentioned in the cover-letter, you are probably missing the clock data.
>> ------------
>> That means for the boot, one clock data patch needs to be applied.
>> It is available on my git tree in 'out_of_tree/omap5_clk_data' branch.
>> ---------------------------------------
> Thanks on the hint, I had missed it. I merged the
> for_3.11/out_of_tree/omap5_clk_data from
> git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux.git
> to linux-next-20130625 with a minor conflict in arch/arm/mach-omap2/io.c
>
> omap2plus_defconfig: http://pastebin.com/rTuEn0H6
> Then applied:
> diff --git a/arch/arm/mach-omap2/voltagedomains54xx_data.c b/arch/arm/mach-omap2/voltagedomains54xx_data.c
> index 72b8971..89a5589f 100644
> --- a/arch/arm/mach-omap2/voltagedomains54xx_data.c
> +++ b/arch/arm/mach-omap2/voltagedomains54xx_data.c
> @@ -89,11 +89,6 @@ void __init omap54xx_voltagedomains_init(void)
> * XXX Will depend on the process, validation, and binning
> * for the currently-running IC. Use OMAP4 data for time being.
> */
> -#ifdef CONFIG_PM_OPP
> - omap5_voltdm_mpu.volt_data = omap446x_vdd_mpu_volt_data;
> - omap5_voltdm_mm.volt_data = omap446x_vdd_iva_volt_data;
> - omap5_voltdm_core.volt_data = omap446x_vdd_core_volt_data;
> -#endif
>
> for (i = 0; voltdm = voltagedomains_omap5[i], voltdm; i++)
> voltdm->sys_clk.name = sys_clk_name;
> Result: http://pastebin.com/t8cdd7uj
>
> As kevin mentioned, we can boot without registering wrong voltage data.
>
With Rajendra's series included now, Yes. Can you send an updated patch with
description for Paul to pick it up ?

Regards,
Santosh