From: Mugunthan V N <mugunthanvnm@ti.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Paul Walmsley <paul@pwsan.com>,
linux-omap@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: USB & hwmon on am33xx
Date: Tue, 9 Jul 2013 23:38:05 +0530 [thread overview]
Message-ID: <51DC5185.4000804@ti.com> (raw)
In-Reply-To: <51DC3B39.6000104@linutronix.de>
On 7/9/2013 10:02 PM, Sebastian Andrzej Siewior wrote:
> Hi Paul,
>
> I'm slowly losing my mind with hwmod.
>
> arch/arm/boot/dts/am33xx.dtsi has the ti,musb-am33xx node.
>
> That one has "usb_otg_hs" as hwmod property.
> The entry for it arch/arm/mach-omap2/omap_hwmod_33xx_data.c uses
> AM33XX_CM_PER_USB0_CLKCTRL_OFFSET (0x1c) as the clk. The TRM only
> mentions this one, i.e. no USB1.
>
> Now I have the following logical devices here:
> - usb0 instance + its glue code for irqs
> - usb1 instance + its glue code for irqs
> - two phy instances, one for USB0 and one USB1
> - one dma engine which serves both usb instances.
>
> Shouldn't I have for each device (usb0/1, phy0/1, dma) a hwmod entry?
> Or is it enough to use the same entry for each device?
Yes, you need hwmod entry for each of the above device. Since USB has only only
clock ctrl register, have one as parrent and make other devices as child node.
you can take CPSW as an example.
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-07-09 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 16:32 USB & hwmon on am33xx Sebastian Andrzej Siewior
2013-07-09 18:08 ` Mugunthan V N [this message]
2013-07-09 20:01 ` Sebastian Andrzej Siewior
2013-07-10 6:07 ` Mugunthan V N
2013-07-29 9:04 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DC5185.4000804@ti.com \
--to=mugunthanvnm@ti.com \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox