From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling Date: Fri, 12 Jul 2013 18:36:30 +0300 Message-ID: <51E0227E.2000008@ti.com> References: <1371826990-25820-1-git-send-email-grygorii.strashko@ti.com> <20130625065811.GZ5523@atomide.com> <51CAEA90.90200@ti.com> <51CC45D3.2000305@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Tony Lindgren , Kevin Hilman , Hebbar Gururaja , "linux-arm-kernel@lists.infradead.org" , Linux-OMAP , "linux-kernel@vger.kernel.org" , Stephen Warren List-Id: linux-omap@vger.kernel.org Hi Linus, On 07/10/2013 11:36 PM, Linus Walleij wrote: > On Thu, Jun 27, 2013 at 4:01 PM, Grygorii Strashko > wrote: > >> I think, In the future the OMAP pinctrl configurations would be manged in >> more flexible way then now (thanks to "pinctrl PM helpers" and you;)) >> - "Idle" state will be splitted to "Idle"/"sleep" >> - "default" state will be splitted to "default"/"active" > > OK so the first ones we already have so the discussion is now down > to adding the "active" state (and pinctrl_pm* helper function). > > I guess we need a patch set prepared which adds the "active" state > and helper function as the first patch, i.e. this: > http://marc.info/?l=linux-kernel&m=137094012703340&w=2 > Can I have your ACK on this patch? I've verified combination of [PATCH] drivers: pinctrl: add active state to core [RFC] ARM: OMAP2+: omap_device: add pinctrl handling on OMAP4 SDP board+UARTs and going to send patches on Monday. So, Acked/Tested-by: Grygorii Strashko (I can't reply directly to thread - not signed to those lists :)) What is the best branch to base my patches on? > > I do not want to add the state unless there is a clear consumer, > so it needs to go in with the first patch to a device driver that uses > pinctrl_pm_select_active_state() which will be a good demonstration > on its use and utility. (And a point to object and suggest other ways > to do the same thing...) > > Yours, > Linus Walleij > Regards, -grygorii