From: Stephen Warren <swarren@wwwdotorg.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-pwm@vger.kernel.org, Rob Herring <rob.herring@calxeda.com>,
linux-omap@vger.kernel.org, Philip Avinash <avinashphilip@ti.com>,
Grant Likely <grant.likely@linaro.org>,
Boris BREZILLON <linux-arm@overkiz.com>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT
Date: Wed, 17 Jul 2013 11:11:19 -0600 [thread overview]
Message-ID: <51E6D037.3020706@wwwdotorg.org> (raw)
In-Reply-To: <2989497.8E7gzkcamn@avalon>
On 07/17/2013 05:00 AM, Laurent Pinchart wrote:
> On Monday 15 July 2013 21:39:31 Stephen Warren wrote:
...
>> But then there's a problem where people assume that the common flags are
>> always available, and somewhere they aren't... Care is needed in the
>> choice of which common flags to define and/or how they're used.
>
> Exactly. That's why I think listing the supported common flags in individual
> bindings makes sense when some of the flags are not supported by all devices.
> As the only PWM flags currently used are common to all PWM devices I can leave
> this out now. I have no strong preference, I'll follow your opinion on this.
Yes, I guess separating the concept of defining common flags and which
devices use them is good. And then indeed individual devices need to
define which of the common flags they support. I'd still like to see the
*definition* of those common flags in some central place (i.e. pwm.txt
or a header that defines constants for it), and the other device
bindings simply reference that for the actual definitions.
next prev parent reply other threads:[~2013-07-17 17:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 14:37 [PATCH 0/2] Add PWM polarity flag macros for DT Laurent Pinchart
2013-07-11 14:37 ` [PATCH 1/2] ARM i.MX53: mba53: Fix PWM backlight DT node Laurent Pinchart
2013-07-12 7:55 ` Shawn Guo
2013-07-11 14:37 ` [PATCH 2/2] pwm: Add PWM polarity flag macros for DT Laurent Pinchart
2013-07-11 15:36 ` Thierry Reding
2013-07-11 17:50 ` Stephen Warren
2013-07-11 19:32 ` Thierry Reding
2013-07-11 20:06 ` Stephen Warren
2013-07-12 11:01 ` Laurent Pinchart
2013-07-12 14:42 ` Stephen Warren
2013-07-16 1:10 ` Laurent Pinchart
2013-07-16 3:39 ` Stephen Warren
2013-07-17 11:00 ` Laurent Pinchart
2013-07-17 17:11 ` Stephen Warren [this message]
2013-07-17 18:20 ` Thierry Reding
2013-07-12 10:50 ` Laurent Pinchart
2013-07-11 17:40 ` Stephen Warren
2013-07-12 10:41 ` Laurent Pinchart
2013-07-12 14:40 ` Stephen Warren
2013-07-12 17:24 ` Thierry Reding
2013-07-12 17:40 ` Stephen Warren
2013-07-16 1:16 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E6D037.3020706@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=avinashphilip@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm@overkiz.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=s.trumtrar@pengutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox