From: Roger Quadros <rogerq@ti.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Regression 3.11-rc1: omap4panda: no usb and consequently no ethernet
Date: Fri, 19 Jul 2013 13:49:46 +0300 [thread overview]
Message-ID: <51E919CA.8060805@ti.com> (raw)
In-Reply-To: <51E916C0.8080206@broadcom.com>
On 07/19/2013 01:36 PM, Arend van Spriel wrote:
> On 07/18/2013 10:59 AM, Tony Lindgren wrote:
>> Then for the SDIO with device tree, take a look at the following
>> patches:
>>
>> [PATCH 0/3] WLAN support for omap4 when booted with devicetree
>> http://comments.gmane.org/gmane.linux.ports.arm.omap/97522#
>
> I have been looking at the pandaboard patch in the series above and I do have a question. Among other things the patch adds these dt entries.
>
> + 0x108 0x118 /* sdmmc5_clk.sdmmc5_clk INPUT_PULLUP | MODE0 */
> + 0x10a 0x118 /* sdmmc5_cmd.sdmmc5_cmd INPUT_PULLUP | MODE0 */
>
> If I look at the similar names in the deceased board-omap4panda.c:
>
> board-omap4panda.c: OMAP4_MUX(SDMMC5_CMD, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
> board-omap4panda.c: OMAP4_MUX(SDMMC5_CLK, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
>
> and in mux44xx.h:
>
> mux44xx.h:#define OMAP4_CTRL_MODULE_PAD_SDMMC5_CLK_OFFSET 0x0148
> mux44xx.h:#define OMAP4_CTRL_MODULE_PAD_SDMMC5_CMD_OFFSET 0x014a
>
> So how did 0x0148 get 0x0108 in DT and 0x014a get 0x010a. There is probably an explanation to it and it would help my understanding to know where this difference comes from. Hope you can help me out here.
>
If you see omap4.dtsi, omap4_pmx_core starts at register address 0x4a100040.
So, you need to subtract 0x40 from the offsets defined in mux44xx.h for pmx_core registers.
NOTE: omap4_pmx_wkup starts at a different address. Those are for wakeup domain
control registers.
cheers,
-roger
next prev parent reply other threads:[~2013-07-19 10:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 8:41 Regression 3.11-rc1: omap4panda: no usb and consequently no ethernet Arend van Spriel
2013-07-18 8:59 ` Tony Lindgren
2013-07-18 10:18 ` Arend van Spriel
2013-07-19 10:36 ` Arend van Spriel
2013-07-19 10:49 ` Roger Quadros [this message]
2013-07-19 10:57 ` Arend van Spriel
2013-10-01 8:05 ` using mmc2 on panda [was: Regression 3.11-rc1: omap4panda: no usb and consequently no ethernet] Arend van Spriel
2013-10-01 9:49 ` Roger Quadros
2013-10-01 9:53 ` Roger Quadros
2013-10-01 10:53 ` Arend van Spriel
2013-10-01 11:29 ` Luca Coelho
2013-10-02 10:20 ` Arend van Spriel
2013-10-02 10:48 ` Luca Coelho
2013-10-01 12:17 ` Roger Quadros
2013-10-01 13:19 ` Balaji T K
2013-10-02 9:03 ` Arend van Spriel
2013-07-19 10:53 ` Regression 3.11-rc1: omap4panda: no usb and consequently no ethernet Tony Lindgren
2013-07-20 7:38 ` Luciano Coelho
2013-07-18 11:18 ` Roger Quadros
2013-07-18 11:24 ` Arend van Spriel
2013-07-18 11:30 ` Roger Quadros
2013-07-18 12:38 ` Arend van Spriel
2013-07-18 12:42 ` Roger Quadros
2013-07-25 13:06 ` Arend van Spriel
2013-07-26 2:49 ` Joel Fernandes
2013-07-26 3:00 ` Joel Fernandes
2013-07-26 7:25 ` Arend van Spriel
2013-07-26 10:13 ` Arend van Spriel
2013-07-26 10:15 ` Arend van Spriel
2013-07-26 10:23 ` Arend van Spriel
2013-07-26 10:37 ` Roger Quadros
2013-07-26 10:40 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E919CA.8060805@ti.com \
--to=rogerq@ti.com \
--cc=arend@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).