From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: George Cherian <george.cherian@ti.com>,
linux-usb@vger.kernel.org, balbi@ti.com,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
linux-omap@vger.kernel.org, kishon@ti.com
Subject: Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX
Date: Fri, 19 Jul 2013 16:20:32 +0200 [thread overview]
Message-ID: <51E94B30.9070805@linutronix.de> (raw)
In-Reply-To: <51E94571.8080805@cogentembedded.com>
On 07/19/2013 03:56 PM, Sergei Shtylyov wrote:
> On 19-07-2013 16:34, George Cherian wrote:
>
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi
>> b/arch/arm/boot/dts/am33xx.dtsi
>> index 8e1248f..e3890c4 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>> @@ -326,21 +326,59 @@
>> status = "disabled";
>> };
>>
>> - usb@47400000 {
>> - compatible = "ti,musb-am33xx";
>> - reg = <0x47400000 0x1000 /* usbss */
>> - 0x47401000 0x800 /* musb instance 0 */
>> - 0x47401800 0x800>; /* musb instance 1 */
>> - interrupts = <17 /* usbss */
>> - 18 /* musb instance 0 */
>> - 19>; /* musb instance 1 */
>> - multipoint = <1>;
>> - num-eps = <16>;
>> - ram-bits = <12>;
>> - port0-mode = <3>;
>> - port1-mode = <3>;
>> - power = <250>;
>> - ti,hwmods = "usb_otg_hs";
>> + phy1: am335x-usb0@44e10620 {
>
> Shouldn't the PHYs be *under* the usb0/1 device nodes in the hierarchy?
> They're not on the same bus as the MUSB controllers for sure.
I redo the complete thing. I have now:
usb: usb@47400000 {
compatible = "ti,am33xx-usb";
usb0_phy: phy@47401300 {
compatible = "ti,am335x-usb-phy";
}
usb0: usb@47401000 {
musb0: usb@47401400 {
compatible = "mg,musbmhdrc";
}
}
usb1_phy: phy@47402300 {
compatible = "ti,am335x-usb-phy";
}
usb1: usb@47402000 {
musb1: usb@47402400 {
compatible = "mg,musbmhdrc";
}
}
}
And you want usb0_phy to be child of usb0? In the TRM they are all in
the same block.
>
> WBR, Sergei
>
Sebastian
next prev parent reply other threads:[~2013-07-19 14:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 12:34 [PATCH v2 0/4] Add phy support for AM335X platform using Generic PHy framework George Cherian
2013-07-19 12:34 ` [PATCH v2 1/4] usb: phy: phy-omap-control: Add API to power and wakeup George Cherian
2013-07-19 13:20 ` Kishon Vijay Abraham I
2013-07-29 14:25 ` Sebastian Andrzej Siewior
2013-07-30 4:53 ` George Cherian
2013-07-30 7:35 ` Sebastian Andrzej Siewior
2013-07-19 12:34 ` [PATCH v2 2/4] phy: phy-amxxxx-usb: Add PHY driver for amxxxx platform George Cherian
2013-07-19 13:32 ` Kishon Vijay Abraham I
2013-07-29 15:17 ` Sebastian Andrzej Siewior
2013-07-30 5:19 ` George Cherian
2013-07-30 8:53 ` Sebastian Andrzej Siewior
2013-07-30 14:24 ` George Cherian
2013-07-30 14:33 ` Felipe Balbi
2013-07-30 14:39 ` Sebastian Andrzej Siewior
2013-07-19 12:34 ` [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX George Cherian
2013-07-19 13:34 ` Kishon Vijay Abraham I
2013-07-19 13:56 ` Sergei Shtylyov
2013-07-19 14:20 ` Sebastian Andrzej Siewior [this message]
2013-07-19 18:33 ` Sergei Shtylyov
2013-07-19 18:42 ` Sebastian Andrzej Siewior
2013-07-20 3:41 ` George Cherian
2013-07-22 5:45 ` George Cherian
2013-07-20 3:36 ` George Cherian
2013-07-19 12:34 ` [PATCH v2 4/4] usb: musb: dsps: Remove the phy control from glue and add phy driver APIs George Cherian
2013-07-19 13:44 ` Kishon Vijay Abraham I
2013-07-19 13:17 ` [PATCH v2 0/4] Add phy support for AM335X platform using Generic PHy framework Kishon Vijay Abraham I
2013-08-10 11:59 ` Ezequiel Garcia
2013-08-14 10:36 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E94B30.9070805@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).