From: Alexander Holler <holler@ahsoftware.de>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
jgchunter@gmail.com, Santosh Shilimkar <santosh.shilimkar@ti.com>,
Tony Lindgren <tony@atomide.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
eballetbo@gmail.com, linux-omap@vger.kernel.org,
Florian Vaussard <florian.vaussard@epfl.ch>,
aaro.koskinen@iki.fi, Balaji T K <balajitk@ti.com>
Subject: Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT
Date: Sun, 28 Jul 2013 16:25:26 +0200 [thread overview]
Message-ID: <51F529D6.8030809@ahsoftware.de> (raw)
In-Reply-To: <51F4F973.8000303@ahsoftware.de>
Am 28.07.2013 12:58, schrieb Alexander Holler:
> This patch basically broke every usage of
>
> irq = gpio_to_irq(gpio);
> request[_threaded]_irq(irq, ...);
>
> because request[_threaded]_irq(irq, ...) now fails because of a missing
> irq_domain (no mapping => no domain).
>
> A prominent victim of this is the omap_hsmmc driver with the cd-gpio
> option enabled. To reproduce it, just add "cd-gpios = <&gpio0 6
> GPIO_ACTIVE_HIGH>;" (or similiar) to the omap-mmc part in the DT.
By the way, if someone decides to touch omap_hsmmc, the driver wrongly
assumes that 0 is not a valid IRQ number and it doesn't check if
gpio_to_irq() returns a negative value. ;)
Regards,
Alexander Holler
next prev parent reply other threads:[~2013-07-28 14:26 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 15:27 [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT Javier Martinez Canillas
2013-06-28 15:27 ` [PATCH v4 2/2] gpio/omap: auto request GPIO as input if used as IRQ via DT Javier Martinez Canillas
2013-06-28 15:32 ` Santosh Shilimkar
2013-06-28 15:28 ` [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT Santosh Shilimkar
2013-06-29 23:44 ` Linus Walleij
2013-06-30 0:25 ` Javier Martinez Canillas
2013-07-01 8:04 ` Linus Walleij
2013-07-01 11:01 ` Javier Martinez Canillas
2013-07-01 12:35 ` Linus Walleij
2013-07-01 12:49 ` Grant Likely
2013-07-01 13:23 ` Linus Walleij
2013-07-28 10:58 ` Alexander Holler
2013-07-28 11:14 ` Linus Walleij
2013-07-28 12:59 ` Alexander Holler
2013-07-28 14:11 ` Linus Walleij
2013-07-28 14:37 ` Shilimkar, Santosh
2013-07-28 16:29 ` Linus Walleij
2013-07-28 17:13 ` Alexander Holler
2013-07-28 18:10 ` Linus Walleij
2013-07-28 17:33 ` Javier Martinez Canillas
2013-07-28 17:36 ` Javier Martinez Canillas
2013-07-28 18:22 ` Linus Walleij
2013-07-28 19:06 ` Javier Martinez Canillas
2013-07-29 6:41 ` Alexander Holler
2013-07-29 8:17 ` Javier Martinez Canillas
2013-07-29 9:13 ` Linus Walleij
2013-07-29 10:27 ` Alexander Holler
2013-07-29 11:11 ` Javier Martinez Canillas
2013-07-29 11:30 ` Alexander Holler
2013-07-29 11:33 ` Alexander Holler
2013-07-29 11:48 ` Linus Walleij
2013-07-29 11:53 ` Balaji T K
2013-07-28 19:30 ` Javier Martinez Canillas
2013-07-29 6:54 ` Alexander Holler
2013-07-28 14:25 ` Alexander Holler [this message]
2013-07-28 16:25 ` Linus Walleij
2013-07-28 16:45 ` Alexander Holler
2013-07-28 17:47 ` Javier Martinez Canillas
2013-07-28 18:06 ` Linus Walleij
2013-07-28 18:50 ` Javier Martinez Canillas
2013-07-29 5:24 ` Alexander Holler
2013-07-29 9:05 ` Linus Walleij
2013-07-29 10:48 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F529D6.8030809@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=aaro.koskinen@iki.fi \
--cc=balajitk@ti.com \
--cc=eballetbo@gmail.com \
--cc=florian.vaussard@epfl.ch \
--cc=grant.likely@linaro.org \
--cc=javier.martinez@collabora.co.uk \
--cc=jgchunter@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).