From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Cousson Subject: Re: [PATCH] arm: omap5: dts: split SMPS10 dt node Date: Tue, 13 Aug 2013 15:21:19 +0200 Message-ID: <520A32CF.1010701@baylibre.com> References: <1376300221-15172-1-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:58472 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757778Ab3HMNVY (ORCPT ); Tue, 13 Aug 2013 09:21:24 -0400 Received: by mail-wg0-f44.google.com with SMTP id l18so6580398wgh.35 for ; Tue, 13 Aug 2013 06:21:22 -0700 (PDT) In-Reply-To: <1376300221-15172-1-git-send-email-kishon@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kishon Vijay Abraham I Cc: benoit.cousson@linaro.org, tony@atomide.com, rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org, ian.campbell@citrix.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, balbi@ti.com Hi Kishon, On 12/08/2013 11:37, Kishon Vijay Abraham I wrote: > SMPS10 has two outputs OUT1 and OUT2. Hence SMPS10 is modeled as > two regulators. The dt node is split to reflect it. Mmm, I'm curious. How is it supposed to work? Do you have dedicated control on each output? Otherwise, it should be seen as one output with two potential consumers. Regards, Benoit > > Signed-off-by: Kishon Vijay Abraham I > --- > arch/arm/boot/dts/omap5-uevm.dts | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts > index 65d7b60..05b9b12 100644 > --- a/arch/arm/boot/dts/omap5-uevm.dts > +++ b/arch/arm/boot/dts/omap5-uevm.dts > @@ -334,9 +334,18 @@ > ti,smps-range = <0x80>; > }; > > - smps10_reg: smps10 { > + smps10_out2_reg: smps10_out2 { > /* VBUS_5V_OTG */ > - regulator-name = "smps10"; > + regulator-name = "smps10_out2"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + smps10_out1_reg: smps10_out1 { > + /* VBUS_5V_OTG */ > + regulator-name = "smps10_out1"; > regulator-min-microvolt = <5000000>; > regulator-max-microvolt = <5000000>; > regulator-always-on; >