Re: [PATCH 2/3] ARM: OMAP2+: Add support to parse optional clk info from DT

[Nishanth Menon <nm@ti.com>]

On 08/14/2013 08:20 AM, Rajendra Nayak wrote:
> On Wednesday 14 August 2013 06:18 PM, Nishanth Menon wrote:
>> Hi Rajendra,
>>
>> On Tue, Jul 23, 2013 at 1:24 AM, Rajendra Nayak <rnayak@ti.com> wrote:
>> [..]
>>> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
>>> index 12fa589..e5c804b 100644
>>> --- a/arch/arm/mach-omap2/omap_hwmod.c
>>> +++ b/arch/arm/mach-omap2/omap_hwmod.c
>>> @@ -805,6 +805,65 @@ static int _init_interface_clks(struct omap_hwmod *oh)
>>>          return ret;
>>>   }
>>>
>>> +static const char **_parse_opt_clks_dt(struct omap_hwmod *oh,
>>> +                                      struct device_node *np,
>>> +                                      int *opt_clks_cnt)
>>> +{
>>> +       int i, clks_cnt;
>>> +       const char *clk_name;
>>> +       const char **opt_clk_names;
>>> +
>>> +       clks_cnt = of_property_count_strings(np, "clock-names");
>>> +       if (!clks_cnt)
>>> +               return NULL;
>>> +
>>> +       opt_clk_names = kzalloc(sizeof(char *)*clks_cnt, GFP_KERNEL);
>>> +       if (!opt_clk_names)
>>> +               return NULL;
>>> +
>>> +       for (i = 0; i < clks_cnt; i++) {
>>> +               of_property_read_string_index(np, "clock-names", i, &clk_name);
>>> +               if (!strcmp(clk_name, "fck"))
>>
>> Could we instead parse for names that are "optional,role_name" instead
>> of assuming anything other than fck is optional clocks?
>
> you mean look for anything with optional,*? because the role names would change.
>

yes. the idea being, we now have a meaning to the clock name - there are 
two types of clocks here.. functional and optional, we *might* have 
facility to add interface clock(we dont know interface clock handling 
yet, but something in the future).. we might increase the support for 
number of functional clocks.. it might help to keep the format such that 
it is a "bit extendable".

>>
>>> +                       continue;
>>> +               opt_clks_cnt++;
>>> +               opt_clk_names[i] = clk_name;
>>> +       }
>>> +       return opt_clk_names;
>>> +}
>>> +
>> [...]
>> --
>> Regards,
>> Nishanth Menon
>>
>


-- 
Regards,
Nishanth Menon