From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v8 0/2] TWL6030, TWL6032 GPADC driver
Date: Thu, 15 Aug 2013 18:59:08 +0100
Message-ID: <520D16EC.90604@kernel.org>
References: <1374758813-6539-1-git-send-email-oleksandr.kozaruk@ti.com>
 <20130815091216.GB28366@e106331-lin.cambridge.arm.com>
 <520CB566.2050201@kernel.org>
 <20130815125906.GA32421@e106331-lin.cambridge.arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org>
In-Reply-To: <20130815125906.GA32421@e106331-lin.cambridge.arm.com>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org
To: Mark Rutland <mark.rutland@arm.com>
Cc: "milo.kim@ti.com" <milo.kim@ti.com>, "lars@metafoo.de" <lars@metafoo.de>, "sameo@linux.intel.com" <sameo@linux.intel.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "tony@atomide.com" <tony@atomide.com>, "poeschel@lemonage.de" <poeschel@lemonage.de>, "rnayak@ti.com" <rnayak@ti.com>, Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "rob.herring@calxeda.com" <rob.herring@calxeda.com>, "kishon@ti.com" <kishon@ti.com>, "peter.ujfalusi@ti.com" <peter.ujfalusi@ti.com>, "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>, "jic23@cam.ac.uk" <jic23@cam.ac.uk>, "grant.likely@linaro.org" <grant.likely@linaro.org>, "benoit.cousson@linaro.org" <benoit.cousson@linaro.org>, "gg@slimlogic.co.uk" <gg@slimlogic.co.uk>, "ch.naveen@samsung.com" <ch.n>
List-Id: linux-omap@vger.kernel.org

On 08/15/13 13:59, Mark Rutland wrote:
> On Thu, Aug 15, 2013 at 12:03:02PM +0100, Jonathan Cameron wrote:
>>
>>>> The changes to the original driver:
>>>> - device tree adaptation;
>>>
>>> I couldn't see a binding document in this series or in mainline. Have I
>>> looked in the wrong places?
>>
>> Nothing explicit supplied, but does it need one given it is doing only
>> iio bindings (bindings/iio/iio-bindings.txt)
>> plus twl child bindings
>> (bindings/mfd/twl-family.txt)
> 
> Every binding needs to be documented.
> 
>>
>> If it does, I guess absolutely everything does, then fair enough!
>> I guess that would make sense as there is no way for someone writing
>> a device tree to know that there is nothing else to be specified.
> 
> Yup, that's why. Also, Linux isn't necessarily the only consumer, and
> other consumers shouldn't need to read Linux code to figure out how a
> particular binding is supposed to look.
> 
Fair enough. Thanks for clearing that up.

Oleksandr, could you send a follow up patch adding the required documentation?
(mostly a cut and paste job from similar elements by the look of it).

Thanks

Jonathan

> Cheers,
> Mark.
>