From: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
To: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
kishon-l0cyMroinI0@public.gmane.org,
george.cherian-l0cyMroinI0@public.gmane.org,
dmurphy-l0cyMroinI0@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 6/8] usb: phy: omap: get rid of omap_get_control_dev()
Date: Fri, 16 Aug 2013 11:07:27 +0200 [thread overview]
Message-ID: <520DEBCF.4@linutronix.de> (raw)
In-Reply-To: <520DEA2B.5030608-l0cyMroinI0@public.gmane.org>
On 08/16/2013 11:00 AM, Roger Quadros wrote:
>> I don't like that part where you can call this function even before the
>> driver probed the device. This shouldn't happen since you have hard module
>> dependency and the proper compatible string in your device. But this
>> kind of thing won't happen in the am335x reset driver.
>
> I don't like that part either, but omap_control_usb_set_mode is being called
> from outside this driver (e.g. musb) and we are not making any changes to that behaviour
> in this patch.
>
> I think the issue you mentioned is being fixed by Kishon's extcon migration series.
Okay then.
>
> cheers,
> -roger
>
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-08-16 9:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 13:15 [PATCH v2 0/8] phy: omap-usb: Support multiple instances and new types Roger Quadros
[not found] ` <1376572512-9561-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-08-15 13:15 ` [PATCH v2 1/8] usb: phy: omap-control: Get rid of platform data Roger Quadros
2013-08-15 16:22 ` Sebastian Andrzej Siewior
2013-08-16 8:57 ` Roger Quadros
2013-08-15 13:15 ` [PATCH v2 2/8] usb: phy: omap: Add new device types and remove omap_control_usb3_phy_power() Roger Quadros
2013-08-15 13:58 ` Benoit Cousson
2013-08-16 9:09 ` Roger Quadros
2013-08-15 13:15 ` [PATCH v2 4/8] usb: phy: omap-usb3: Don't use omap_get_control_dev() Roger Quadros
2013-08-15 13:15 ` [PATCH v2 6/8] usb: phy: omap: get rid of omap_get_control_dev() Roger Quadros
[not found] ` <1376572512-9561-7-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-08-15 16:51 ` Sebastian Andrzej Siewior
2013-08-16 9:00 ` Roger Quadros
[not found] ` <520DEA2B.5030608-l0cyMroinI0@public.gmane.org>
2013-08-16 9:07 ` Sebastian Andrzej Siewior [this message]
2013-08-15 13:15 ` [PATCH v2 3/8] usb: phy: omap-usb2: Don't use omap_get_control_dev() Roger Quadros
2013-08-15 13:15 ` [PATCH v2 5/8] usb: musb: omap2430: " Roger Quadros
2013-08-15 13:15 ` [PATCH v2 7/8] ARM: dts: omap4: update omap-control-usb nodes Roger Quadros
2013-08-15 13:15 ` [PATCH v2 8/8] ARM: dts: omap5: update omap-control-usb node Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520DEBCF.4@linutronix.de \
--to=bigeasy-hfztesqfncyowbw4kg4ksq@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmurphy-l0cyMroinI0@public.gmane.org \
--cc=george.cherian-l0cyMroinI0@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rogerq-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).