From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gururaja Hebbar Subject: Re: [PATCH v3 0/2] rtc: omap: update AM335x rtc ip revision Date: Fri, 16 Aug 2013 17:44:54 +0530 Message-ID: <520E17BE.2050008@ti.com> References: <1376653017-21935-1-git-send-email-gururaja.hebbar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1376653017-21935-1-git-send-email-gururaja.hebbar-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-omap@vger.kernel.org Hi All, Kindly ignore this series. there is mistake/typo because of which it will not directly apply. I will resend the patch-set. sorry for the trouble. regards Gururaja On 8/16/2013 5:06 PM, Hebbar, Gururaja wrote: > The syntax of compatible property in DT is to mention the Most specific > match to most generic match. > > Since AM335x is the platform with latest IP revision, add it 1st in > the device id table. > > This way, we can add new matching compatible as 1st and maintain old > compatible string for backwards compatibility. > > ex: > compatible = "ti,am3352-rtc", "ti,da830-rtc"; > > Also, update am335x .dtsi file (am33xx.dtsi) as above. > > Note: > This is a part of previously submitted patch-set [1]. Out of 4 patches, > 3 was accepted and 1 got an acceptable NAK. Hence resubmitting only the > rejected + updated changes. > > Changes in V3: > - As per Mark Rutland's suggestion [2], maintain old compatible > string and add the new matching string as the 1st compatible. > > Changes in V2: > - Coding style corrections (remove extra space, use lower case > for hex numbers > - use prefix ARM: for commit subject keeping with arch/arm > convention) > - use "[AM/am]3352" instead of "[AM/am]335x" to keep the all > usages in sync. > - Use index defined for struct members so they remain in sync > - Add new compatible to existing one so that when driver > supports enhanced features of hardware, they are available > to the user else the basic functionality still works > > [2] > https://lkml.org/lkml/2013/7/3/74 > [1] > https://lkml.org/lkml/2013/8/1/442 > > Hebbar Gururaja (1): > ARM: dts: AM33XX: update rtc node compatibility > > Hebbar, Gururaja (1): > rtc: omap: update of_device_id to reflect latest ip revisions > > arch/arm/boot/dts/am33xx.dtsi | 2 +- > drivers/rtc/rtc-omap.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) >