From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Cousson Subject: Re: [PATCH v3 7/8] ARM: dts: omap4: update omap-control-usb nodes Date: Fri, 16 Aug 2013 16:30:51 +0200 Message-ID: <520E379B.4090108@baylibre.com> References: <1376658571-20992-1-git-send-email-rogerq@ti.com> <1376658571-20992-8-git-send-email-rogerq@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f169.google.com ([74.125.82.169]:64851 "EHLO mail-we0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751933Ab3HPOaz (ORCPT ); Fri, 16 Aug 2013 10:30:55 -0400 Received: by mail-we0-f169.google.com with SMTP id n5so1728319wev.28 for ; Fri, 16 Aug 2013 07:30:54 -0700 (PDT) In-Reply-To: <1376658571-20992-8-git-send-email-rogerq@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Roger Quadros Cc: balbi@ti.com, tony@atomide.com, george.cherian@ti.com, kishon@ti.com, bigeasy@linutronix.de, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Hi Roger, Sorry I missed something in the previous revision :-( On 16/08/2013 15:09, Roger Quadros wrote: > Split otghs_ctrl and USB2 PHY power down into separate > omap-control-usb nodes. Get rid of "ti,type" property. You should add that you update the usb_otg_hs node accordingly as well. > CC: Benoit Cousson > Signed-off-by: Roger Quadros > --- > arch/arm/boot/dts/omap4.dtsi | 20 ++++++++++++-------- > 1 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi > index 22d9f2b..a77dd0a 100644 > --- a/arch/arm/boot/dts/omap4.dtsi > +++ b/arch/arm/boot/dts/omap4.dtsi > @@ -519,7 +519,7 @@ > usb2_phy: usb2phy@4a0ad080 { > compatible = "ti,omap-usb2"; > reg = <0x4a0ad080 0x58>; > - ctrl-module = <&omap_control_usb>; > + ctrl-module = <&omap_control_usb2phy>; > }; > }; > > @@ -643,12 +643,16 @@ > }; > }; > > - omap_control_usb: omap-control-usb@4a002300 { > - compatible = "ti,omap-control-usb"; > - reg = <0x4a002300 0x4>, > - <0x4a00233c 0x4>; > - reg-names = "control_dev_conf", "otghs_control"; > - ti,type = <1>; > + omap_control_usb2phy: omap-control-usb@4a002300 { > + compatible = "ti,usb2-control-usb"; > + reg = <0x4a002300 0x4>; > + reg-names = "power"; > + }; > + > + omap_control_usbotg: omap-control-usb@4a00233c { > + compatible = "ti,omap4-control-usb"; > + reg = <0x4a00233c 0x4>; > + reg-names = "otghs_control"; > }; > > usb_otg_hs: usb_otg_hs@4a0ab000 { > @@ -661,7 +665,7 @@ > multipoint = <1>; > num-eps = <16>; > ram-bits = <12>; > - ti,has-mailbox; > + ctrl-module = <&omap_control_usbotg>; In omap-usb.txt, ti,has-mailbox is still marked as mandatory whereas the ctrl-module is optional. You should update the usb-otg-hs bindings as well. BTW, why is that property not prefixed with "ti,"? Is ctrl-module really meaningful for other arch? Regards, Benoit