From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Cousson Subject: Re: [PATCH v2 0/2] omap4/twl6030: typical connection to omap4 as a separate dtsi file Date: Mon, 19 Aug 2013 12:04:30 +0200 Message-ID: <5211EDAE.1090407@baylibre.com> References: <1376469348-10797-1-git-send-email-ruslan.bilovol@ti.com> <520B8B45.1010300@baylibre.com> <520E2726.304@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ruslan Bilovol Cc: Nishanth Menon , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , uri.y@variscite.com, linux-omap , linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org Hi Ruslan, On 19/08/2013 08:14, Ruslan Bilovol wrote: > Hi Benoit, > > On Fri, Aug 16, 2013 at 4:20 PM, Benoit Cousson wrote: >> Hi Ruslan, >> >> On 16/08/2013 14:04, Ruslan Bilovol wrote: >>> Hi Benoit, >>> >>> On Wed, Aug 14, 2013 at 4:51 PM, Benoit Cousson wrote: >>>> Hi Ruslan, >>>> >>>> On 14/08/2013 10:35, Ruslan Bilovol wrote: >>>>> >>>>> Hello, >>>>> >>>>> There is no functional changes between v1 and v2 - just >>>>> added the patch for omap4-var-som - Uri Yosef confirmed >>>>> this board have the same connection of OMAP4<->TWL6030 as >>>>> SDP4430 board >>>> >>>> >>>> The series looks good to me, but it will be good to have a test for Panda >>>> and Variscite boards before merging it. >>> >>> Okay, so I just verified this patch series on PandaBoard ES2. Should I >>> resubmit this series with >>> fixed commit message? >> >> No, that's fine, I already applied it and fixed the subject and the changelog. >> >> Here it is: >> >> commit 2e25df1e5a4af906a9b25332719ace000063eb0d >> Author: Ruslan Bilovol >> Date: Wed Aug 14 11:35:47 2013 +0300 >> >> ARM: dts: twl6030: Move common configuration for OMAP4 boards in a separate dtsi file >> >> The OMAP4 SoC family uses specially-designed PMIC (power management IC) >> companion chip for power management needs: TWL6030/TWL6032. >> Therefore there is a typical connection of PMIC to OMAP4 so we can >> move it into separate .dtsi file and do not duplicate over >> board-specific files. >> >> Tested on OMAP4 SDP board and compile-tested for Panda board > > Just for archives: I've successfully tested it on PandaBoard ES2 last > week as well. Great, I'll update the changelog before pushing it. >> Signed-off-by: Ruslan Bilovol >> Signed-off-by: Benoit Cousson >> >> >> Just let me know if you are OK with the updated version. > > Yes, this version looks good to me. Thanks for picking it up! > >> >>> However I cannot verify the patch for Variscite board because I do not >>> own any such board so >>> you can drop that patch. But maybe Uri Yosef can verify it. Uri? >> >> It seems that Uri cannot test it right now, so I will have to drop that one. > > Okay, let's wait for Uri's verification. I'll keep it for 3.13. Thanks, Benoit