From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tero Kristo Subject: Re: [PATCHv5 22/31] CLK: TI: add interface clock support for OMAP3 Date: Mon, 19 Aug 2013 16:54:28 +0300 Message-ID: <52122394.9040904@ti.com> References: <1375460751-23676-1-git-send-email-t-kristo@ti.com> <1375460751-23676-23-git-send-email-t-kristo@ti.com> <20130813113010.GN27165@e106331-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:51934 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736Ab3HSNy7 (ORCPT ); Mon, 19 Aug 2013 09:54:59 -0400 In-Reply-To: <20130813113010.GN27165@e106331-lin.cambridge.arm.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Mark Rutland Cc: "linux-omap@vger.kernel.org" , "paul@pwsan.com" , "tony@atomide.com" , "nm@ti.com" , "rnayak@ti.com" , "mturquette@linaro.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" On 08/13/2013 02:30 PM, Mark Rutland wrote: > On Fri, Aug 02, 2013 at 05:25:41PM +0100, Tero Kristo wrote: >> OMAP3 has interface clocks in addition to functional clocks, which >> require special handling for the autoidle and idle status register >> offsets mainly. >> >> Signed-off-by: Tero Kristo >> --- >> .../devicetree/bindings/clock/ti/interface.txt | 45 +++++++++ >> arch/arm/mach-omap2/clock.h | 6 -- >> drivers/clk/ti/Makefile | 2 +- >> drivers/clk/ti/interface.c | 105 ++++++++++++++++++++ >> include/linux/clk/ti.h | 7 ++ >> 5 files changed, 158 insertions(+), 7 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/clock/ti/interface.txt >> create mode 100644 drivers/clk/ti/interface.c >> >> diff --git a/Documentation/devicetree/bindings/clock/ti/interface.txt b/Documentation/devicetree/bindings/clock/ti/interface.txt >> new file mode 100644 >> index 0000000..8b09ae7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/ti/interface.txt >> @@ -0,0 +1,45 @@ >> +Binding for Texas Instruments interface clock. >> + >> +This binding uses the common clock binding[1]. This clock is >> +quite much similar to the basic gate-clock [2], however, >> +it supports a number of additional features, including >> +companion clock finding (match corresponding functional gate >> +clock) and hardware autoidle enable / disable. >> + >> +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt >> +[2] Documentation/devicetree/bindings/clock/gate-clock.txt >> + >> +Required properties: >> +- compatible : shall be "ti,interface-clock" > > It might make sense to be more specific: "ti,omap3-interface-clock". Ok. > >> +- #clock-cells : from common clock binding; shall be set to 0 >> +- clocks : link to phandle of parent clock >> +- reg : base address for the control register >> + >> +Optional properties: >> +- ti,enable-bit : bit shift for the bit enabling/disabling the clock >> + (default 0) >> +- ti,iclk-no-wait : flag for selecting non-waiting hw-ops >> +- ti,iclk-hsotgusb : flag for selecting hsotgusb hw-ops >> +- ti,iclk-dss : flag for selecting DSS interface clock hw-ops >> +- ti,iclk-ssi : flag for selecting SSI interface clock hw-ops >> +- ti,am35xx-clk : flag for selecting AM35xx interface clock hw-ops > > I think these should be selected based on the compatible string. They're > mutually exclusive, and incompatible. Ok, I'll change this for next rev so that each has its own compatible string. Thanks for your comments Mark. -Tero