From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <archit@ti.com>
Cc: robdclark@gmail.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH] drm: omap: fix: Defer probe if an omapdss device requests for it at connect
Date: Fri, 20 Sep 2013 13:22:04 +0300 [thread overview]
Message-ID: <523C21CC.1010503@ti.com> (raw)
In-Reply-To: <523C20DC.2090100@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]
On 20/09/13 13:18, Archit Taneja wrote:
> On Friday 20 September 2013 02:25 PM, Tomi Valkeinen wrote:
>> On 20/09/13 11:49, Archit Taneja wrote:
>>
>>> I suppose we would hit this case if all of the displays are deferred
>>> because of some dependency and are probed after omapdrm probes.
>>>
>>> Is that the case with beagle-xm?
>>
>> Yes, DVI is probed after omapdrm. There's also analog TV out on beagle.
>> I'm not sure why that wasn't ready earlier, or was it available at all.
>> I didn't study it further.
>>
>> If the analog tv would've been available, omapdrm would have started
>> with only tv out, and DVI would have been left out. So it's still not
>> perfect.
>
> Right, I suppose omapdrm should be probed only after all the dssdevs are
> probed. That's a bit tough to do.
Yes. Omapfb has the same issue.
>>> I think we need to move this from pdev_probe() anyway. I don't see other
>>> drivers doing much in pdev_probe(), they do most of their stuff in
>>> dev_load() itself. I'll try with that along with disabling of the
>>> dssdevs in encoder's destroy.
>>
>> Ok. The dssdevs are disabled in omap_connector already, though.
>
> I couldn't find where it is disabled in omap_connector. The only
> function which calls dssdrv->disable is omap_connector_set_enabled().
> That doesn't seem to be called in omap_connector.
Ah, right. Sorry, it seems I remembered totally wrong. I guess I was
thinking about omap_dss_put_device instead.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2013-09-20 10:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 11:08 [PATCH] drm: omap: fix: Defer probe if an omapdss device requests for it at connect Archit Taneja
2013-09-18 11:15 ` Archit Taneja
2013-09-18 12:41 ` Tomi Valkeinen
2013-09-18 13:17 ` Archit Taneja
2013-09-18 13:26 ` Tomi Valkeinen
2013-09-19 8:49 ` [PATCH 1/2] " Archit Taneja
2013-09-19 8:49 ` [PATCH 2/2] drm: omap: disconnect devices when omapdrm module is removed Archit Taneja
2013-09-19 10:08 ` Tomi Valkeinen
2013-09-19 10:51 ` Archit Taneja
2013-09-20 8:09 ` [PATCH] drm: omap: fix: Defer probe if an omapdss device requests for it at connect Tomi Valkeinen
2013-09-20 8:49 ` Archit Taneja
2013-09-20 8:55 ` Tomi Valkeinen
2013-09-20 10:18 ` Archit Taneja
2013-09-20 10:22 ` Tomi Valkeinen [this message]
2013-10-07 9:38 ` [PATCH v2 0/2] drm: omap: Fix omapdrm probe and module insertion/removal issues Archit Taneja
2013-10-07 9:38 ` [PATCH v2 1/2] drm: omap: fix: Defer probe if an omapdss device requests for it at connect Archit Taneja
2013-10-07 9:38 ` [PATCH v2 2/2] drm: omap: disconnect devices when omapdrm module is removed Archit Taneja
2013-10-09 13:56 ` [PATCH v2 0/2] drm: omap: Fix omapdrm probe and module insertion/removal issues Archit Taneja
2013-10-21 9:38 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523C21CC.1010503@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).