Re: [PATCH v2 3/4] usb: musb: omap2430: use SIMPLE_DEV_PM_OPS

[Daniel Mack <zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On 22.09.2013 16:59, Sergei Shtylyov wrote:
> On 22-09-2013 18:43, Daniel Mack wrote:
> 
>> This makes omap2430_pm_ops const and will stub the struct out in case
>> CONFIG_PM_SLEEP is not set.
> 
>> Signed-off-by: Daniel Mack <zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>>   drivers/usb/musb/omap2430.c | 15 +++++----------
>>   1 file changed, 5 insertions(+), 10 deletions(-)
> 
>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
>> index 59d2245..be42460 100644
>> --- a/drivers/usb/musb/omap2430.c
>> +++ b/drivers/usb/musb/omap2430.c
>> @@ -659,17 +659,12 @@ static int omap2430_runtime_resume(struct device *dev)
>>
>>   	return 0;
>>   }
>> -
>> -static struct dev_pm_ops omap2430_pm_ops = {
>> -	.runtime_suspend = omap2430_runtime_suspend,
>> -	.runtime_resume = omap2430_runtime_resume,
>> -};
>> -
>> -#define DEV_PM_OPS	(&omap2430_pm_ops)
>> -#else
>> -#define DEV_PM_OPS	NULL
>>   #endif
>>
>> +static SIMPLE_DEV_PM_OPS(omap2430_pm_ops,
>> +			 omap2430_runtime_suspend,
>> +			 omap2430_runtime_resume);
> 
>     No, SIMPLE_DEV_PM_OPS() won't do here, it's runtime PM, didn't you see?

Eh, you're right, sorry. Whoever applies this series, just drop that one
patch. The rest of this series is not affected.

Sergei, thanks for the review again :)


Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html