linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
To: Daniel Mack <zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	neumann-SRDuVqtxQLSzQB+pC5nmwQ@public.gmane.org,
	vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH v2 2/5] usb: musb: call musb_port_suspend from musb_bus_suspend
Date: Wed, 02 Oct 2013 14:01:17 +0200	[thread overview]
Message-ID: <524C0B0D.3020300@linutronix.de> (raw)
In-Reply-To: <524C001B.8040901-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On 10/02/2013 01:14 PM, Daniel Mack wrote:
> On 02.10.2013 12:49, Sebastian Andrzej Siewior wrote:
>> * Daniel Mack | 2013-10-01 15:39:54 [+0200]:
>>
>>> Make musb_port_suspend() externally available, and call it when to host
>>> goes into suspend. This allows the core to go into suspend while a
>>> device is connected.
>>
>> Sorry for asking this stupid question but what is usally happening when
>> the host goes to suspend and a device is connected? I think it is
>> disconnected & re-enumerated and resume and this not what you want,
>> right?
> 
> It is usually put into USB suspend and the host preserves its state.
> After resume, the usb storage driver, for example, will not register new
> partitions but expect things to be as they were before. That is, your
> previously mounted devices remain functional.
> 
> However, the enumeration process has to be done again, because when the
> device looses power, it can't memorize its address.
> 
>> What happens if the device is unplugged while the host is suspended and
>> not there on resume?
> 
> That condition is detected and a full teardown of the connected drivers
> is conducted. Try what happens on your notebook when you do that.
> Embedded systems should behave just the same.

I had the feeling that the USB device gets disconnected and
re-enumerated on resume. But if you say that the ehci-hcd saves the
state and keeps the device connected if it wasn't disconnected during
suspend then there is no reason for musb to behave differently.

> Daniel

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2013-10-02 12:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01 13:39 [PATCH v2 0/5] usb: musb_dsps: support for suspend and resume Daniel Mack
2013-10-01 13:39 ` [PATCH v2 1/5] usb: musb: move port reset to worker Daniel Mack
2013-10-02 10:46   ` Sebastian Andrzej Siewior
2013-10-02 11:19     ` Daniel Mack
     [not found] ` <1380634797-29541-1-git-send-email-zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-01 13:39   ` [PATCH v2 2/5] usb: musb: call musb_port_suspend from musb_bus_suspend Daniel Mack
2013-10-02 10:49     ` Sebastian Andrzej Siewior
2013-10-02 11:14       ` Daniel Mack
     [not found]         ` <524C001B.8040901-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-02 12:01           ` Sebastian Andrzej Siewior [this message]
2013-10-02 12:12             ` Daniel Mack
     [not found]               ` <524C0D94.8050100-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-02 14:52                 ` Alan Stern
2013-10-01 13:39 ` [PATCH v2 3/5] usb: musb: conditionally save and restore the context on suspend Daniel Mack
2013-10-01 13:39 ` [PATCH v2 4/5] usb: musb: dsps: add {tx,rx}_mode to wrapper Daniel Mack
2013-10-01 13:39 ` [PATCH v2 5/5] usb: musb: dsps: add support for suspend and resume Daniel Mack
2013-10-01 14:59   ` Felipe Balbi
2013-10-01 15:04     ` Daniel Mack
     [not found]       ` <524AE464.3020201-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-01 16:03         ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524C0B0D.3020300@linutronix.de \
    --to=bigeasy-hfztesqfncyowbw4kg4ksq@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=neumann-SRDuVqtxQLSzQB+pC5nmwQ@public.gmane.org \
    --cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).