linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: bcousson@baylibre.com, Tony Lindgren <tony@atomide.com>,
	Enric Balletbo i Serra <eballetbo@gmail.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support
Date: Mon, 7 Oct 2013 13:43:20 +0300	[thread overview]
Message-ID: <52529048.1040606@ti.com> (raw)
In-Reply-To: <1380931479-16142-2-git-send-email-javier.martinez@collabora.co.uk>

Javier,

On 10/05/2013 03:04 AM, Javier Martinez Canillas wrote:
> Commit ad871c10b ("ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards")
> added USB OTG support for most OMAP boards but some OMAP3 boards
> such as the IGEPv2 were not updated. This patch adds an USB OTG
> device node to this board.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>  arch/arm/boot/dts/omap3-igep0020.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts
> index eedf0d8..903e944 100644
> --- a/arch/arm/boot/dts/omap3-igep0020.dts
> +++ b/arch/arm/boot/dts/omap3-igep0020.dts
> @@ -166,3 +166,10 @@
>  		smsc,save-mac-address;
>  	};
>  };
> +
> +&usb_otg_hs {
> +	interface-type = <0>;
> +	usb-phy = <&usb2_phy>;

With the PHY generic framework in Greg's usb-next branch [1], you will also need to add

+       phys = <&usb2_phy>;
+       phy-names = "usb2-phy";

> +	mode = <3>;
> +	power = <50>;
> +};
> 

So it would be good to test with the usb-next branch.

cheers,
-roger

[1] - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git

  parent reply	other threads:[~2013-10-07 10:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-05  0:04 [PATCH 0/3] ARM: dts: omap3-igep0020: improvements for v3.13 Javier Martinez Canillas
2013-10-05  0:04 ` [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support Javier Martinez Canillas
2013-10-06 10:26   ` Enric Balletbo Serra
2013-10-07 10:43   ` Roger Quadros [this message]
2013-10-07 11:54     ` Javier Martinez Canillas
2013-10-07 11:58       ` Benoit Cousson
2013-10-07 12:02         ` Javier Martinez Canillas
2013-10-07 12:09           ` Benoit Cousson
2013-10-07 16:05             ` Javier Martinez Canillas
2013-10-05  0:04 ` [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support Javier Martinez Canillas
2013-10-06 10:27   ` Enric Balletbo Serra
2013-10-07  8:33   ` Roger Quadros
2013-10-07  8:50     ` Javier Martinez Canillas
     [not found]       ` <525275C8.2050208-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2013-10-07  9:06         ` Roger Quadros
2013-10-07  9:13           ` Javier Martinez Canillas
2013-10-07 10:22             ` Javier Martinez Canillas
2013-10-07 10:42               ` Roger Quadros
2013-10-07 11:53                 ` Javier Martinez Canillas
2013-10-05  0:04 ` [PATCH 3/3] ARM: dts: omap3-igep0020: use standard constant for IRQ flags Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52529048.1040606@ti.com \
    --to=rogerq@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=eballetbo@gmail.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).