From: Mark Jackson <mpfj-list@newflow.co.uk>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-usb@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@ti.com>, Greg KH <gregkh@linuxfoundation.org>,
jkosina@suse.cz, anatol.pomozov@gmail.com,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Bin Liu <binmlist@gmail.com>
Subject: Re: [PATCH] Allow MUSB DSPS to use "force host" mode
Date: Fri, 22 Nov 2013 17:07:46 +0000 [thread overview]
Message-ID: <528F8F62.7000801@newflow.co.uk> (raw)
In-Reply-To: <528F8DF1.2060307@linutronix.de>
On 22/11/13 17:01, Sebastian Andrzej Siewior wrote:
> On 11/22/2013 05:49 PM, Mark Jackson wrote:
>>> and the ID pin not on ground or 3.3V?
>>> What are the side effects? I remember correctly Bin wanted to avoid
>>> settings this if it could be avoided.
>>
>> Yes ... we have a host only USB port and an unconnected ID pin.
>
> Is it too late to connect that pin?
Unfortunately, yes.
The USB portion of the CPU board has not been needed until now, and
although I did know about the unconnected pin, I also knew it could be
fixed in s/w, so I wasn't too concerned.
>> AFAIK it defaults to device mode so I can't see any devices that get
>> plugged into the USB port.
>>
>> If I tweak the s/w to "force" host mode on, then everything appears to
>> work okay.
>>
>> I guess it's more of a hardware oversight that we left the pin floating
>> but in the real world, I guess someone may want this feature to they
>> can change the usb port type ?
>
> This is something I would prefer to avoid if possible. We have the
> dr_mode attribute in DT. Based on that one we act as a device or host.
> Now if you decide (via dr_mode) either for host or device that means we
> have to set that bit. Where I feel a little uncomfortable is when
> someone having OTG runs in hostmode and attaches a host.
>
>>
>> Either way, I need to fix the current h/w (which can be done via s/w)
>> hence the patch.
> I've seen many projects where this pin has been forgotten and it could
> not be changed in SW and they patched the HW. Usually this is noticed
> in the early phase and a wire is just soldered and the redesign has it
> fixed. So I don't think that this is a big issue.
> Do you insists on having this change merged upstream?
No ... I didn't think it would be such an issue, so I'm happy to keep this
as a local patch if that's any better.
Mark J.
next prev parent reply other threads:[~2013-11-22 17:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 15:55 [PATCH] Allow MUSB DSPS to use "force host" mode Mark Jackson
2013-11-22 16:33 ` Sebastian Andrzej Siewior
2013-11-22 16:49 ` Mark Jackson
2013-11-22 17:01 ` Sebastian Andrzej Siewior
2013-11-22 17:07 ` Mark Jackson [this message]
2013-11-22 17:22 ` Sebastian Andrzej Siewior
[not found] ` <528F7E8F.5050807-2FZW7xY0fHgqdlJmJB21zg@public.gmane.org>
2013-11-22 16:38 ` Michael Grzeschik
2013-11-22 16:45 ` Mark Jackson
2013-11-25 21:24 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528F8F62.7000801@newflow.co.uk \
--to=mpfj-list@newflow.co.uk \
--cc=anatol.pomozov@gmail.com \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=binmlist@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).