From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Roger Quadros <rogerq@ti.com>
Cc: Michael Trimarchi <michael@amarulasolutions.com>,
Felipe Balbi <balbi@ti.com>,
lee.jones@linaro.org, sameo@linux.intel.com,
tomi.valkeinen@ti.com, Stefan Roese <sr@denx.de>,
ljkenny.mailinglists@gmail.com,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Keshava Munegowda <keshava_mgowda@ti.com>
Subject: Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda
Date: Mon, 02 Dec 2013 14:04:15 +0100 [thread overview]
Message-ID: <529C854F.3010101@linutronix.de> (raw)
In-Reply-To: <529C7922.5000601@ti.com>
On 12/02/2013 01:12 PM, Roger Quadros wrote:
> You are right. The musb hwmod data doesn't have the HWMOD_INIT_NO_RESET
> flag, so hwmod should reset it during boot.
>
> Maybe I too should just remove HWMOD_INIT_NO_RESET flag from the USB Host
> hwmod data, then we don't need to change this driver at all.
>
> Benoit, Tony any comments?
Almost two years ago in commit de231388 ("ARM: OMAP: USB: EHCI and OHCI
hwmod structures for OMAP3") the "don't reset flag" has been added by
Keshava.
It refers to "Errata Id:i660" why it is required. Once you figured what
why it has been added you could have an idea if it is okay to remove it
and if the reset you do here might lead to it (I dunno).
>
> cheers,
> -roger
Sebastian
next prev parent reply other threads:[~2013-12-02 13:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 13:01 [PATCH 0/1] mfd: omap-usb-host: Bug fix for 3.13 rc Roger Quadros
2013-11-29 13:01 ` [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda Roger Quadros
2013-11-29 13:17 ` David Laight
2013-12-02 8:39 ` Roger Quadros
2013-12-02 16:28 ` David Laight
2013-12-03 9:43 ` Roger Quadros
[not found] ` <1385730118-26402-2-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-11-29 15:32 ` Michael Trimarchi
2013-12-02 9:41 ` Roger Quadros
2013-12-02 12:01 ` Sebastian Andrzej Siewior
2013-12-02 12:12 ` Roger Quadros
2013-12-02 13:04 ` Sebastian Andrzej Siewior [this message]
2013-12-02 13:35 ` Roger Quadros
2013-12-02 13:39 ` Sebastian Andrzej Siewior
2013-12-02 13:44 ` Roger Quadros
[not found] ` <529C8ED0.6060805-l0cyMroinI0@public.gmane.org>
2013-12-02 14:03 ` Sebastian Andrzej Siewior
2013-12-02 15:12 ` Roger Quadros
2013-11-30 4:48 ` Michael Trimarchi
2013-11-30 5:10 ` Michael Trimarchi
2013-12-01 3:14 ` Michael Trimarchi
2013-12-02 9:39 ` Roger Quadros
2013-12-02 9:51 ` Michael Trimarchi
[not found] ` <CAOf5uwmpiOv_GED23hWDArcOvs6DpHNEy=OJ9vnKem1pg8jSgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-02 12:05 ` Roger Quadros
2013-12-02 15:00 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C854F.3010101@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=balbi@ti.com \
--cc=keshava_mgowda@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ljkenny.mailinglists@gmail.com \
--cc=michael@amarulasolutions.com \
--cc=rogerq@ti.com \
--cc=sameo@linux.intel.com \
--cc=sr@denx.de \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).