linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: "Enric Balletbo Serra" <eballetbo@gmail.com>,
	"Gupta, Pekon" <pekon@ti.com>,
	"Javier Martinez Canillas" <javier@dowhile0.org>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Javier Martinez Canillas" <martinez.javier@gmail.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>,
	"Scott Wood (scottwood@freescale.com)" <scottwood@freescale.com>
Subject: Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.
Date: Mon, 2 Dec 2013 11:00:35 -0500	[thread overview]
Message-ID: <529CAEA3.2080808@ti.com> (raw)
In-Reply-To: <20131202165103.726314d9@skate>

On 12/02/2013 10:51 AM, Thomas Petazzoni wrote:
> Dear Enric Balletbo Serra,
> 
> On Mon, 2 Dec 2013 16:39:09 +0100, Enric Balletbo Serra wrote:
> 
>> Thanks for the explanations to all.
>>
>> Although the new ECC schema breaks the compatibility between the board
>> files and new DT based kernel, I think we should use BCH8 scheme.
>> Sorry, because I had not realized that this was configurable in
>> u-boot, so I think, if Thomas is also agree, the better fix in that
>> case is change CONFIG_NAND_OMAP_ECCSCHEME to
>> OMAP_ECC_BCH8_CODE_HW_DETECTION_SW in u-boot. If this works we can
>> discard this patch.
> 
> I theoretically don't have anything against that, but if I do this
> change in U-Boot, and then use U-Boot to reflash to NAND the SPL and
> U-Boot itself, will the OMAP ROM code still be able to read the SPL
> from NAND ? I'm not sure which ECC scheme does the OMAP ROM code
> support, and how it detects (or not) which ECC scheme to use to read
> the SPL.

Yes, this brings us back to one of the old and long-standing problems.
The ROM on these devices will generally speak one format and that means
using NAND chips that say for the first block (or N blocks or whatever)
you only need 1bit ECC but for the rest 4/8/16/whatever.  And then
informing the kernel (and anything else) that "partitions" N need this
format and the rest need that.

-- 
Tom

  reply	other threads:[~2013-12-02 16:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-01 11:23 [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility Enric Balletbo i Serra
2013-12-01 12:27 ` Javier Martinez Canillas
2013-12-02 10:54   ` Thomas Petazzoni
2013-12-02 14:16     ` Enric Balletbo Serra
2013-12-02 14:56       ` Gupta, Pekon
2013-12-02 15:02         ` Thomas Petazzoni
2013-12-02 15:19           ` Gupta, Pekon
2013-12-02 15:39             ` Enric Balletbo Serra
2013-12-02 15:51               ` Thomas Petazzoni
2013-12-02 16:00                 ` Tom Rini [this message]
2013-12-02 16:06                   ` Thomas Petazzoni
2013-12-02 16:13                     ` Gupta, Pekon
2013-12-02 16:19                       ` Thomas Petazzoni
2013-12-02 17:05                         ` Gupta, Pekon
2013-12-02 17:16                           ` Michael Trimarchi
2013-12-02 17:46                             ` Gupta, Pekon
2013-12-02 18:09                               ` Tom Rini
2013-12-02 17:25                           ` Tom Rini
2013-12-06 19:52                           ` Scott Wood
2013-12-02 16:19                       ` Tom Rini
2013-12-02 16:21                       ` Javier Martinez Canillas
2013-12-02 16:24                         ` Tom Rini
2013-12-02 16:46                           ` Javier Martinez Canillas
2013-12-02 16:57                             ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529CAEA3.2080808@ti.com \
    --to=trini@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=eballetbo@gmail.com \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=javier@dowhile0.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=martinez.javier@gmail.com \
    --cc=pekon@ti.com \
    --cc=scottwood@freescale.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).