From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH] mmc: omap: Fix error introduced by fix to release_mem_region() path Date: Tue, 03 Dec 2013 18:16:59 +0000 Message-ID: <529E201B.6030306@bitmer.com> References: <20131202193459.GL26766@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131202193459.GL26766@atomide.com> Sender: linux-mmc-owner@vger.kernel.org To: Tony Lindgren Cc: Chris Ball , linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, Dan Carpenter , Aaro Koskinen , Jarkko Lavinen List-Id: linux-omap@vger.kernel.org On 12/02/2013 07:34 PM, Tony Lindgren wrote: > Commit 31ee9181eb92: (mmc: omap: Fix DMA configuration to not rely > on device id) fixed getting of the DMA resources when booted with > device tree. This patch however changed the handling of the > free_mem_region() error path by reusing the struct resource *res > for the DMA resources. > > Fix the error the same way omap_hsmmc.c driver handles it, which > is to restore the resource before using the values to call > release_mem_region(). > > Reported-by: Dan Carpenter > Signed-off-by: Tony Lindgren > I guess my devm_ioremap conversion would have fixed this? http://www.spinics.net/lists/linux-mmc/msg23317.html Does not help now but I'm thinking if queuing some of those my patches (3-5) on top of yours as a fix? Especially fix to NULL pointer dereference: http://www.spinics.net/lists/linux-mmc/msg23320.html -- Jarkko