linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
	linux-omap@vger.kernel.org
Subject: Re: [pandaboard] omap-aes L3 standard error
Date: Tue, 3 Dec 2013 19:45:52 -0600	[thread overview]
Message-ID: <529E8950.4030209@ti.com> (raw)
In-Reply-To: <529E47B5.60900@math.uni-bielefeld.de>

On 12/03/2013 03:05 PM, Tobias Jakobi wrote:
> Hello,
> 
> here a newly introduced one:
> https://bugzilla.kernel.org/show_bug.cgi?id=66441

[1] solves the issue

However, digging further, the root of the crash starts here:
"platform 4b501000.aes: Cannot lookup hwmod 'aes'"
with this, the following happens:
a) omap_device does not register a pm_domain (since it cannot find
hwmod entry).
b) driver does not know about (a), does a pm_runtime_get_sync which
never fails
c) tries to read the revision register (as part of probe) without clock.
generates the issue mentioned above.


Now, there are three issues here:
a) hwmod entries are not present -> this is addressed in [1]
b) omap_device pm_domain is not handled - fixed in [2]
c) aes driver needs to handle error case when pm_runtime_get_sync
fails. addressed in [3].

[1] http://marc.info/?l=linux-kernel&m=138541593010221&w=2 +
http://marc.info/?l=linux-kernel&m=138541603810300&w=2

[2] https://patchwork.kernel.org/patch/3280531/
[3] https://patchwork.kernel.org/patch/3280571/

-- 
Regards,
Nishanth Menon

      reply	other threads:[~2013-12-04  1:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03 21:05 [pandaboard] omap-aes L3 standard error Tobias Jakobi
2013-12-04  1:45 ` Nishanth Menon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529E8950.4030209@ti.com \
    --to=nm@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).