From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v2 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy Date: Mon, 9 Dec 2013 11:37:40 +0530 Message-ID: <52A55E2C.7070500@ti.com> References: <1386331571-30903-1-git-send-email-kishon@ti.com> <1386331571-30903-3-git-send-email-kishon@ti.com> <20131206210835.GM21086@saruman.home> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131206210835.GM21086@saruman.home> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: balbi@ti.com, Tony Lindgren , Linux Kernel Cc: Russell King , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Javier Martinez Canillas , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-omap@vger.kernel.org Hi, On Saturday 07 December 2013 02:38 AM, Felipe Balbi wrote: > Hi, > > On Fri, Dec 06, 2013 at 01:14:38PM +0100, Javier Martinez Canillas wrote: >> On Fri, Dec 6, 2013 at 1:06 PM, Kishon Vijay Abraham I wrote: >>> Previously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while creating >>> MUSB core device. So in usb_bind_phy (binds the controller with the PHY), the >>> device name of the controller had *.auto* in it. Since with using >>> PLATFORM_DEVID_AUTO, there is no way to know the exact device name in advance, >>> the data given in usb_bind_phy became obsolete and usb_get_phy was failing. >>> So MUSB wrapper was modified not to use PLATFORM_DEVID_AUTO. Corresponding >>> change is done in board file here. >>> >>> Signed-off-by: Kishon Vijay Abraham I >>> --- >>> arch/arm/mach-omap2/board-2430sdp.c | 2 +- >>> arch/arm/mach-omap2/board-3430sdp.c | 2 +- >>> arch/arm/mach-omap2/board-cm-t35.c | 2 +- >>> arch/arm/mach-omap2/board-devkit8000.c | 2 +- >>> arch/arm/mach-omap2/board-ldp.c | 2 +- >>> arch/arm/mach-omap2/board-omap3beagle.c | 2 +- >>> arch/arm/mach-omap2/board-omap3logic.c | 2 +- >>> arch/arm/mach-omap2/board-omap3pandora.c | 2 +- >>> arch/arm/mach-omap2/board-omap3stalker.c | 2 +- >>> arch/arm/mach-omap2/board-omap3touchbook.c | 2 +- >>> arch/arm/mach-omap2/board-overo.c | 2 +- >>> arch/arm/mach-omap2/board-rx51.c | 2 +- >>> 12 files changed, 12 insertions(+), 12 deletions(-) >>> >> >> You can drop this patch since boards files are being removed for v3.14 > > if we can drop this patch, the whole series is invalid, since we'll be > using DT phandles to find PHYs going forward, no ? > yeah. But in one of the other threads, Tony seemed ok to take a patch that fixes the same issue in mach-omap2/twl-common.c. So it's better to confirm with Tony. Thanks Kishon