From: Mugunthan V N <mugunthanvnm@ti.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-omap@vger.kernel.org,
george.cherian@ti.com
Subject: Re: [PATCH 1/1] drivers: net : cpsw: Use netdev_name while requesting irq
Date: Mon, 9 Dec 2013 14:59:05 +0530 [thread overview]
Message-ID: <52A58D61.9060404@ti.com> (raw)
In-Reply-To: <20131206.154640.2274056773488827363.davem@davemloft.net>
On Saturday 07 December 2013 02:16 AM, David Miller wrote:
> From: Mugunthan V N <mugunthanvnm@ti.com>
> Date: Fri, 6 Dec 2013 12:28:27 +0530
>
>> From: George Cherian <george.cherian@ti.com>
>>
>> Use netdev_name while requesting irq so that eth* name is shown
>> in /proc/interrupts. Previously it was showing device name as (null)
>> for cpsw interrupts. For using netdev_name register_netdev and then
>> call devm_request_irq.
>>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> Why is it showing "(null)" as the name, is dev_name() not working
> properly for this device?
>
> The only change you are making is passing netdev_name() instead
> of dev_name(). dev_name() giving NULL doesn't make much sense
> to me.
priv->dev is a network device which is registered to network stack after
request interrupt, so dev name is null, with this patch request
interrupt is moved below after registering the network device with the
network
Initial driver was using DT node name for the interrupts, but with the
devm changes by Daniel Mack in commit 50a5fb068 it was changed to ndev
name which introduced this issue.
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-12-09 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 6:58 [PATCH 1/1] drivers: net : cpsw: Use netdev_name while requesting irq Mugunthan V N
2013-12-06 20:46 ` David Miller
2013-12-09 9:29 ` Mugunthan V N [this message]
2013-12-10 0:57 ` David Miller
2013-12-10 8:32 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A58D61.9060404@ti.com \
--to=mugunthanvnm@ti.com \
--cc=davem@davemloft.net \
--cc=george.cherian@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).