From: Stefan Roese <sr@denx.de>
To: "Gupta, Pekon" <pekon@ti.com>,
Enric Balletbo Serra <eballetbo@iseebcn.com>,
Javier Martinez Canillas <javier@dowhile0.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Igor Grinberg <grinberg@compulab.co.il>,
Michael Trimarchi <michael@amarulasolutions.com>,
Nikita Kiryanov <nikita@compulab.co.il>,
"jp.francois@cynove.com" <jp.francois@cynove.com>,
"ivan.djelic@parrot.com" <ivan.djelic@parrot.com>
Cc: "Woodruff, Richard" <r-woodruff2@ti.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
"Rini, Tom" <trini@ti.com>,
"avinashphilipk@gmail.com" <avinashphilipk@gmail.com>,
"r.meier@siemens.com" <r.meier@siemens.com>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Balbi, Felipe" <balbi@ti.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Scott Wood <scottwood@freescale.com>,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v1 0/2] mtd: nand: omap: booting from NAND using u-boot
Date: Mon, 06 Jan 2014 12:48:12 +0100 [thread overview]
Message-ID: <52CA97FC.4020300@denx.de> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EA5E07C@DBDE04.ent.ti.com>
Hi Pekon,
On 06.01.2014 08:40, Gupta, Pekon wrote:
> Hello Enric, Nikita, and other OMAP3 users,
>
>>
>> As there were parallel set of patches running between u-boot and kernel.
>> hence, some patch-sets caused regression for OMAP3x platforms when booting
>> using u-boot specifically for ecc-schemes (like BCH4_SW).
>>
>> Hence this patch series fixes those regressions, and tests complete
>> NAND boot sequence for multiple ecc-schemes on AM335x-EVM board.
>> (following configurations are required for building u-boot driver which is
>> compatible to kernel ecclayout for selected ecc-scheme)
>>
>>
>> (BCH8_HW) (HAM1_HW) (HAM1_HW) (HAM1_HW) (UBIFS)
>> ROM ---------> SPL ---------> U-Boot ---------> Kernel ---------> File-System
>>
>> (BCH8_HW) (BCH8_SW) (BCH8_SW) (BCH8_SW) (UBIFS)
>> ROM ---------> SPL ---------> U-Boot ---------> Kernel ---------> File-System
>>
>> (BCH8_HW) (BCH8_HW) (BCH8_HW) (BCH8_HW) (UBIFS)
>> ROM ---------> SPL ---------> U-Boot ---------> Kernel ---------> File-System
>>
>> *Configurations used to build u-boot and kernel for end-to-end NAND boot*
>> +------------+--------------------------------------------+------------------+
>> | ecc-scheme | u-boot/SPL configs | kernel DTS |
>> +------------+--------------------------------------------+------------------+
>> | | | |
>> | HAM1_HW | #define CONFIG_NAND_OMAP_ECCSCHEME \ |ti,nand-ecc-opts= |
>> | | OMAP_ECC_HAM1_CODE_HW | "ham1" |
>> | (1-bit | #define CONFIG_SYS_NAND_ECCBYTES 3 | |
>> | Hamming | #define CONFIG_SYS_NAND_ECCPOS \ | |
>> | using h/w) | { 1, 2, 3, 4, 5, 6, 7, 8, 9, \ | |
>> | | 10, 11, 12 } | |
>> | | (for NAND page-size=2048) | |
>> | | | |
>> +------------+--------------------------------------------+------------------+
>> | | | |
>> | BCH8_SW | #define CONFIG_NAND_OMAP_ECCSCHEME \ |ti,nand-ecc-opts= |
>> | | OMAP_ECC_BCH8_CODE_HW_DETECTION_SW | "bch8" |
>> |(8-bit BCH | #define CONFIG_SYS_NAND_ECCBYTES 13 |(without ELM node)|
>> | using s/w | #define CONFIG_BCH | |
>> |library for | #undef CONFIG_SPL_NAND_AM33XX_BCH | |
>> |for ECC | #define CONFIG_SPL_NAND_SIMPLE | |
>> | error | #define CONFIG_SYS_NAND_ECCPOS \ | |
>> |correction) | {2, 3, 4, 5, 6, 7, 8, 9, 10, \ | |
>> | | 11, 12, 13, 14, \ | |
>> | | 16, 17, 18, 19, 20, 21, 22, 23, 24, \ | |
>> | | 25, 26, 27, 28, \ | |
>> | | 30, 31, 32, 33, 34, 35, 36, 37, 38, \ | |
>> | | 39, 40, 41, 42, \ | |
>> | | 44, 45, 46, 47, 48, 49, 50, 51, 52, \ | |
>> | | 53, 54, 55, 56, } | |
>> | | (for NAND page-size=2048) | |
>> | | #define CONFIG_SYS_NAND_ECCSIZE 512 | |
>> | | | |
>> +------------+--------------------------------------------+------------------+
>> | | | |
>> | BCH8_HW | #define CONFIG_NAND_OMAP_ECCSCHEME \ |ti,nand-ecc-opts= |
>> | | OMAP_ECC_BCH8_CODE_HW | "bch8" |
>> |(8-bit BCH | #define CONFIG_SYS_NAND_ECCBYTES 14 | |
>> | using ELM | #define CONFIG_SPL_NAND_AM33XX_BCH |(with ELM node) |
>> | h/w engine | #define CONFIG_SYS_NAND_ECCPOS \ |ti,elm-id=<&elm> |
>> |for ECC | {2, 3, 4, 5, 6, 7, 8, 9, \ | |
>> | error | 10, 11, 12, 13, 14, 15, 16, 17, \ | |
>> |correction) | 18, 19, 20, 21, 22, 23, 24, 25, \ | |
>> | | 26, 27, 28, 29, 30, 31, 32, 33, \ | |
>> | | 34, 35, 36, 37, 38, 39, 40, 41, \ | |
>> | | 42, 43, 44, 45, 46, 47, 48, 49, \ | |
>> | | 50, 51, 52, 53, 54, 55, 56, 57, } | |
>> | | (for NAND page-size=2048) | |
>> | | #define CONFIG_SYS_NAND_ECCSIZE 512 | |
>> | | | |
>> +------------+--------------------------------------------+------------------+
>>
>> #* In addition following patches need to be pulled for u-boot:
>> http://lists.denx.de/pipermail/u-boot/2013-December/168506.html
>> http://lists.denx.de/pipermail/u-boot/2013-December/169021.html
>>
>>
>> Test1: flash ubi image from u-boot and boot the kernel
>> U-boot> mw 0x82000000 0xff <u-boot.img size aligned to NAND block boundary>
>> U-boot> fatload mmc 0 0x82000000 u-boot.img
>> U-boot> nand erase <u-boot_offset> <u-boot.img size>
>> U-boot> nand write 0x82000000 <u-boot_offset> <u-boot.img size>
>> U-boot> setenv bootargs 'console=ttyO0,115200n8 noinitrd mem=256M \
>> root=ubi0 rw rootfstype=ubifs ubi.mtd=<mtdpart-of-rootfs>,\
>> <page-size> ip=off init=/init'
>> U-boot> bootm <kernel_offset>
>>
>> Test2: update u-boot.img from kernel and re-boot
>> Kernel> flash_erase /dev/<mtdpart-of-u-boot> 0 0
>> Kernel> nandwrite -s 0 /dev/<mtdpart-of-u-boot> u-boot.img
>> Kernel> reboot
>>
>> Signed-off-by: Pekon Gupta <pekon@ti.com>
>> ---
>
> Though I have done initial level of testing on AM335x as mentioned above,
> But will it be possible for you to test and confirm if these set of patches
> solve regressions on your OMAP3 boards ?
Those patches work fine on our custom AM335x board. So:
Tested-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2014-01-06 11:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 9:12 [PATCH v1 0/2] mtd: nand: omap: booting from NAND using u-boot Pekon Gupta
2013-12-13 9:12 ` [PATCH v1 1/2] mtd: nand: omap: fix ecclayout->oobfree->offset Pekon Gupta
2014-01-25 8:56 ` Brian Norris
2014-02-12 11:33 ` Gupta, Pekon
2013-12-13 9:12 ` [PATCH v1 2/2] mtd: nand: omap: fix ecclayout to be in sync with u-boot NAND driver Pekon Gupta
2014-01-25 8:57 ` Brian Norris
2014-01-06 7:40 ` [PATCH v1 0/2] mtd: nand: omap: booting from NAND using u-boot Gupta, Pekon
2014-01-06 11:48 ` Stefan Roese [this message]
2014-01-14 14:27 ` Enric Balletbo Serra
2014-01-15 4:01 ` Gupta, Pekon
2014-01-25 8:55 ` Brian Norris
2014-01-28 7:42 ` Gupta, Pekon
2014-02-04 11:30 ` Gupta, Pekon
2014-02-11 23:40 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CA97FC.4020300@denx.de \
--to=sr@denx.de \
--cc=avinashphilipk@gmail.com \
--cc=balbi@ti.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=eballetbo@iseebcn.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=grinberg@compulab.co.il \
--cc=ivan.djelic@parrot.com \
--cc=javier@dowhile0.org \
--cc=jp.francois@cynove.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=nikita@compulab.co.il \
--cc=pekon@ti.com \
--cc=r-woodruff2@ti.com \
--cc=r.meier@siemens.com \
--cc=scottwood@freescale.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).