From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Subject: Re: [PATCH v1 0/2] mtd: nand: omap: booting from NAND using u-boot Date: Mon, 06 Jan 2014 12:48:12 +0100 Message-ID: <52CA97FC.4020300@denx.de> References: <1386925978-23705-1-git-send-email-pekon@ti.com> <20980858CB6D3A4BAE95CA194937D5E73EA5E07C@DBDE04.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EA5E07C@DBDE04.ent.ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: "Gupta, Pekon" , Enric Balletbo Serra , Javier Martinez Canillas , Thomas Petazzoni , Igor Grinberg , Michael Trimarchi , Nikita Kiryanov , "jp.francois@cynove.com" , "ivan.djelic@parrot.com" Cc: "Woodruff, Richard" , Artem Bityutskiy , Brian Norris , "Rini, Tom" , "avinashphilipk@gmail.com" , "r.meier@siemens.com" , "u-boot@lists.denx.de" , "linux-mtd@lists.infradead.org" , "Balbi, Felipe" , Ezequiel Garcia , Scott Wood , linux-omap List-Id: linux-omap@vger.kernel.org Hi Pekon, On 06.01.2014 08:40, Gupta, Pekon wrote: > Hello Enric, Nikita, and other OMAP3 users, > >> >> As there were parallel set of patches running between u-boot and kernel. >> hence, some patch-sets caused regression for OMAP3x platforms when booting >> using u-boot specifically for ecc-schemes (like BCH4_SW). >> >> Hence this patch series fixes those regressions, and tests complete >> NAND boot sequence for multiple ecc-schemes on AM335x-EVM board. >> (following configurations are required for building u-boot driver which is >> compatible to kernel ecclayout for selected ecc-scheme) >> >> >> (BCH8_HW) (HAM1_HW) (HAM1_HW) (HAM1_HW) (UBIFS) >> ROM ---------> SPL ---------> U-Boot ---------> Kernel ---------> File-System >> >> (BCH8_HW) (BCH8_SW) (BCH8_SW) (BCH8_SW) (UBIFS) >> ROM ---------> SPL ---------> U-Boot ---------> Kernel ---------> File-System >> >> (BCH8_HW) (BCH8_HW) (BCH8_HW) (BCH8_HW) (UBIFS) >> ROM ---------> SPL ---------> U-Boot ---------> Kernel ---------> File-System >> >> *Configurations used to build u-boot and kernel for end-to-end NAND boot* >> +------------+--------------------------------------------+------------------+ >> | ecc-scheme | u-boot/SPL configs | kernel DTS | >> +------------+--------------------------------------------+------------------+ >> | | | | >> | HAM1_HW | #define CONFIG_NAND_OMAP_ECCSCHEME \ |ti,nand-ecc-opts= | >> | | OMAP_ECC_HAM1_CODE_HW | "ham1" | >> | (1-bit | #define CONFIG_SYS_NAND_ECCBYTES 3 | | >> | Hamming | #define CONFIG_SYS_NAND_ECCPOS \ | | >> | using h/w) | { 1, 2, 3, 4, 5, 6, 7, 8, 9, \ | | >> | | 10, 11, 12 } | | >> | | (for NAND page-size=2048) | | >> | | | | >> +------------+--------------------------------------------+------------------+ >> | | | | >> | BCH8_SW | #define CONFIG_NAND_OMAP_ECCSCHEME \ |ti,nand-ecc-opts= | >> | | OMAP_ECC_BCH8_CODE_HW_DETECTION_SW | "bch8" | >> |(8-bit BCH | #define CONFIG_SYS_NAND_ECCBYTES 13 |(without ELM node)| >> | using s/w | #define CONFIG_BCH | | >> |library for | #undef CONFIG_SPL_NAND_AM33XX_BCH | | >> |for ECC | #define CONFIG_SPL_NAND_SIMPLE | | >> | error | #define CONFIG_SYS_NAND_ECCPOS \ | | >> |correction) | {2, 3, 4, 5, 6, 7, 8, 9, 10, \ | | >> | | 11, 12, 13, 14, \ | | >> | | 16, 17, 18, 19, 20, 21, 22, 23, 24, \ | | >> | | 25, 26, 27, 28, \ | | >> | | 30, 31, 32, 33, 34, 35, 36, 37, 38, \ | | >> | | 39, 40, 41, 42, \ | | >> | | 44, 45, 46, 47, 48, 49, 50, 51, 52, \ | | >> | | 53, 54, 55, 56, } | | >> | | (for NAND page-size=2048) | | >> | | #define CONFIG_SYS_NAND_ECCSIZE 512 | | >> | | | | >> +------------+--------------------------------------------+------------------+ >> | | | | >> | BCH8_HW | #define CONFIG_NAND_OMAP_ECCSCHEME \ |ti,nand-ecc-opts= | >> | | OMAP_ECC_BCH8_CODE_HW | "bch8" | >> |(8-bit BCH | #define CONFIG_SYS_NAND_ECCBYTES 14 | | >> | using ELM | #define CONFIG_SPL_NAND_AM33XX_BCH |(with ELM node) | >> | h/w engine | #define CONFIG_SYS_NAND_ECCPOS \ |ti,elm-id=<&elm> | >> |for ECC | {2, 3, 4, 5, 6, 7, 8, 9, \ | | >> | error | 10, 11, 12, 13, 14, 15, 16, 17, \ | | >> |correction) | 18, 19, 20, 21, 22, 23, 24, 25, \ | | >> | | 26, 27, 28, 29, 30, 31, 32, 33, \ | | >> | | 34, 35, 36, 37, 38, 39, 40, 41, \ | | >> | | 42, 43, 44, 45, 46, 47, 48, 49, \ | | >> | | 50, 51, 52, 53, 54, 55, 56, 57, } | | >> | | (for NAND page-size=2048) | | >> | | #define CONFIG_SYS_NAND_ECCSIZE 512 | | >> | | | | >> +------------+--------------------------------------------+------------------+ >> >> #* In addition following patches need to be pulled for u-boot: >> http://lists.denx.de/pipermail/u-boot/2013-December/168506.html >> http://lists.denx.de/pipermail/u-boot/2013-December/169021.html >> >> >> Test1: flash ubi image from u-boot and boot the kernel >> U-boot> mw 0x82000000 0xff >> U-boot> fatload mmc 0 0x82000000 u-boot.img >> U-boot> nand erase >> U-boot> nand write 0x82000000 >> U-boot> setenv bootargs 'console=ttyO0,115200n8 noinitrd mem=256M \ >> root=ubi0 rw rootfstype=ubifs ubi.mtd=,\ >> ip=off init=/init' >> U-boot> bootm >> >> Test2: update u-boot.img from kernel and re-boot >> Kernel> flash_erase /dev/ 0 0 >> Kernel> nandwrite -s 0 /dev/ u-boot.img >> Kernel> reboot >> >> Signed-off-by: Pekon Gupta >> --- > > Though I have done initial level of testing on AM335x as mentioned above, > But will it be possible for you to test and confirm if these set of patches > solve regressions on your OMAP3 boards ? Those patches work fine on our custom AM335x board. So: Tested-by: Stefan Roese Thanks, Stefan ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/