linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Joachim Eastwood <manabian@gmail.com>, linux-omap@vger.kernel.org
Subject: Re: omap4 and cpufreq
Date: Mon, 6 Jan 2014 10:28:50 -0600	[thread overview]
Message-ID: <52CAD9C2.2020307@ti.com> (raw)
In-Reply-To: <CAGhQ9Vzx-WyCHUurK-2vxS0i_T3SCGGnhq3FfKGhGzbMCeYAqA@mail.gmail.com>

On 01/01/2014 04:37 PM, Joachim Eastwood wrote:
> Hi,
> 
> I am bringing up a OMAP4460 board on dt and I saw the following messages
> in the kernel log from "cpufreq-cpu0".
> [ 2.373352] cpufreq_cpu0: failed to get cpu0 regulator: -19
> [ 2.379302] cpufreq_cpu0: failed to get cpu0 clock: -2
> [ 2.384704] cpufreq-cpu0: probe of cpufreq-cpu0.0 failed with error -2
> 
> Failure to get the clock is because OMAP4 seems to be lacking a "cpu0" entry
> in cclock44xx_data.c. Adding "CLK("cpu0", NULL, &dpll_mpu_ck)," to
> "omap44xx_clks" seems to do the trick. This is what OMAP3 has anyways. Think
> this failure was caused by commit 60c5fc86d which switched from
> "omap-cpufreq" to "cpufreq-cpu0" driver on dt boot.

This is part of the transition to device tree based clock nodes. See:
https://bugzilla.kernel.org/show_bug.cgi?id=58541

for details.
> 
> As far as I can see it makes cpufreq work again. I at least get the
> cpufreq nodes in sysfs and can play around with them.
> 
> Should I submit a patch for cclock44xx_data.c adding "cpu0"?
No. cclock44xx_data is on the way to be dead.

> 
> Next up is the regulator. Since my board is a 4460 and it seems that
> tps63261 support for 4460 never made it to mainline I guess I am out of
> luck here?
> 
> But for all 4430 boards in mainline I guess it would be nice to add:
> &twl {
>     vdd1: regulator-vdd1 {
>         compatible = "ti,twl6030-vdd1";
>         regulator-min-microvolt = <1000000>;
>         regulator-max-microvolt = <1400000>;
>     };
> };
> cpus {
>     cpu@0 {
>         cpu0-supply = <&vdd1>;
>     };
> };
> 
> I assume this would work but I don't have a 4430 board to test it on.
> Unsure about voltage range, but at least 1.0 to 1.4V covers the operation
> points for cpu in omap443xx.dtsi.
This will not work. 6030 does not allow voltage to be set over i2c1,
needs voltage controller/processor to work.





-- 
Regards,
Nishanth Menon

  reply	other threads:[~2014-01-06 16:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-01 22:37 omap4 and cpufreq Joachim Eastwood
2014-01-06 16:28 ` Nishanth Menon [this message]
2014-01-06 21:51   ` Joachim Eastwood
2014-01-06 22:02     ` Nishanth Menon
2014-01-06 22:24       ` Joachim Eastwood
2014-01-06 22:43         ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CAD9C2.2020307@ti.com \
    --to=nm@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=manabian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).