* [PATCH 0/2] ARM: DRA7XX/AM43XX build fixes
@ 2014-01-10 9:57 Tero Kristo
2014-01-10 9:57 ` [PATCH 1/2] ARM: DRA7XX/AM43XX: randconfig fixes Tero Kristo
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Tero Kristo @ 2014-01-10 9:57 UTC (permalink / raw)
To: linux-omap, tony, mturquette; +Cc: linux-arm-kernel
Hi,
The move of clock code from mach-omap2 to drivers/clk/ti introduces
a couple of new build errors with AM43XX/DRA7XX only builds. The
following patches address these issues by modifying the Kconfig + Makefile
under mach-omap2.
Also, it seems DRA7XX only build is not possible at the moment, added
patch #2 to fix this.
-Tero
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/2] ARM: DRA7XX/AM43XX: randconfig fixes 2014-01-10 9:57 [PATCH 0/2] ARM: DRA7XX/AM43XX build fixes Tero Kristo @ 2014-01-10 9:57 ` Tero Kristo 2014-01-10 16:14 ` Felipe Balbi 2014-01-10 9:57 ` [PATCH 2/2] ARM: DRA7XX: Add support for DRA7XX only build Tero Kristo 2014-01-13 16:24 ` [PATCH 0/2] ARM: DRA7XX/AM43XX build fixes Felipe Balbi 2 siblings, 1 reply; 8+ messages in thread From: Tero Kristo @ 2014-01-10 9:57 UTC (permalink / raw) To: linux-omap, tony, mturquette; +Cc: linux-arm-kernel DRA7XX and AM43XX were missing common clock code from the Makefile, which causes build breakage in DRA7XX / AM43XX only builds once clock support for these SoCs is added. Add the missing entries to the Makefile as preparation of this. Signed-off-by: Tero Kristo <t-kristo@ti.com> --- arch/arm/mach-omap2/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 088305f..96a990f 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile @@ -191,6 +191,9 @@ obj-$(CONFIG_ARCH_OMAP4) += dpll3xxx.o dpll44xx.o obj-$(CONFIG_SOC_AM33XX) += $(clock-common) dpll3xxx.o obj-$(CONFIG_SOC_OMAP5) += $(clock-common) obj-$(CONFIG_SOC_OMAP5) += dpll3xxx.o dpll44xx.o +obj-$(CONFIG_SOC_DRA7XX) += $(clock-common) +obj-$(CONFIG_SOC_DRA7XX) += dpll3xxx.o dpll44xx.o +obj-$(CONFIG_SOC_AM43XX) += $(clock-common) dpll3xxx.o # OMAP2 clock rate set data (old "OPP" data) obj-$(CONFIG_SOC_OMAP2420) += opp2420_data.o -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: DRA7XX/AM43XX: randconfig fixes 2014-01-10 9:57 ` [PATCH 1/2] ARM: DRA7XX/AM43XX: randconfig fixes Tero Kristo @ 2014-01-10 16:14 ` Felipe Balbi 0 siblings, 0 replies; 8+ messages in thread From: Felipe Balbi @ 2014-01-10 16:14 UTC (permalink / raw) To: Tero Kristo; +Cc: linux-omap, tony, mturquette, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 419 bytes --] On Fri, Jan 10, 2014 at 11:57:29AM +0200, Tero Kristo wrote: > DRA7XX and AM43XX were missing common clock code from the Makefile, which > causes build breakage in DRA7XX / AM43XX only builds once clock support > for these SoCs is added. Add the missing entries to the Makefile as > preparation of this. > > Signed-off-by: Tero Kristo <t-kristo@ti.com> Reviewed-by: Felipe Balbi <balbi@ti.com> -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: DRA7XX: Add support for DRA7XX only build 2014-01-10 9:57 [PATCH 0/2] ARM: DRA7XX/AM43XX build fixes Tero Kristo 2014-01-10 9:57 ` [PATCH 1/2] ARM: DRA7XX/AM43XX: randconfig fixes Tero Kristo @ 2014-01-10 9:57 ` Tero Kristo 2014-01-10 16:15 ` Felipe Balbi 2014-01-13 16:24 ` [PATCH 0/2] ARM: DRA7XX/AM43XX build fixes Felipe Balbi 2 siblings, 1 reply; 8+ messages in thread From: Tero Kristo @ 2014-01-10 9:57 UTC (permalink / raw) To: linux-omap, tony, mturquette; +Cc: linux-arm-kernel SOC_DRA7XX was under wrong menu within Kconfig file, which prevented DRA7XX only build. Fixed the kconfig options for this SoC as we are there. voltage.c needs to be added to the DRA7XX build also, otherwise DRA7XX only build will fail. Signed-off-by: Tero Kristo <t-kristo@ti.com> --- arch/arm/mach-omap2/Kconfig | 18 ++++++++++-------- arch/arm/mach-omap2/Makefile | 1 + 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index dc21df1..e65948a 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -76,6 +76,16 @@ config SOC_AM43XX select ARM_GIC select MACH_OMAP_GENERIC +config SOC_DRA7XX + bool "TI DRA7XX" + depends on ARCH_MULTI_V7 + select ARCH_OMAP2PLUS + select ARM_CPU_SUSPEND if PM + select ARM_GIC + select CPU_V7 + select HAVE_SMP + select HAVE_ARM_ARCH_TIMER + config ARCH_OMAP2PLUS bool select ARCH_HAS_BANDGAP @@ -128,14 +138,6 @@ config SOC_HAS_REALTIME_COUNTER depends on SOC_OMAP5 || SOC_DRA7XX default y -config SOC_DRA7XX - bool "TI DRA7XX" - select ARM_ARCH_TIMER - select CPU_V7 - select ARM_GIC - select HAVE_SMP - select COMMON_CLK - comment "OMAP Core Type" depends on ARCH_OMAP2 diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 96a990f..8ebe9f3 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile @@ -132,6 +132,7 @@ obj-$(CONFIG_SOC_AM33XX) += $(voltagedomain-common) obj-$(CONFIG_SOC_AM43XX) += $(voltagedomain-common) obj-$(CONFIG_SOC_OMAP5) += $(voltagedomain-common) obj-$(CONFIG_SOC_OMAP5) += voltagedomains54xx_data.o +obj-$(CONFIG_SOC_DRA7XX) += $(voltagedomain-common) # OMAP powerdomain framework powerdomain-common += powerdomain.o powerdomain-common.o -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: DRA7XX: Add support for DRA7XX only build 2014-01-10 9:57 ` [PATCH 2/2] ARM: DRA7XX: Add support for DRA7XX only build Tero Kristo @ 2014-01-10 16:15 ` Felipe Balbi 2014-01-10 16:32 ` Tero Kristo 0 siblings, 1 reply; 8+ messages in thread From: Felipe Balbi @ 2014-01-10 16:15 UTC (permalink / raw) To: Tero Kristo; +Cc: tony, linux-omap, mturquette, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 1547 bytes --] On Fri, Jan 10, 2014 at 11:57:30AM +0200, Tero Kristo wrote: > SOC_DRA7XX was under wrong menu within Kconfig file, which prevented > DRA7XX only build. Fixed the kconfig options for this SoC as we are > there. voltage.c needs to be added to the DRA7XX build also, otherwise > DRA7XX only build will fail. > > Signed-off-by: Tero Kristo <t-kristo@ti.com> one comment below, other than that: Reviewed-by: Felipe Balbi <balbi@ti.com> > --- > arch/arm/mach-omap2/Kconfig | 18 ++++++++++-------- > arch/arm/mach-omap2/Makefile | 1 + > 2 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index dc21df1..e65948a 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -76,6 +76,16 @@ config SOC_AM43XX > select ARM_GIC > select MACH_OMAP_GENERIC > > +config SOC_DRA7XX > + bool "TI DRA7XX" > + depends on ARCH_MULTI_V7 > + select ARCH_OMAP2PLUS > + select ARM_CPU_SUSPEND if PM > + select ARM_GIC > + select CPU_V7 > + select HAVE_SMP > + select HAVE_ARM_ARCH_TIMER > + > config ARCH_OMAP2PLUS > bool > select ARCH_HAS_BANDGAP > @@ -128,14 +138,6 @@ config SOC_HAS_REALTIME_COUNTER > depends on SOC_OMAP5 || SOC_DRA7XX > default y > > -config SOC_DRA7XX > - bool "TI DRA7XX" > - select ARM_ARCH_TIMER > - select CPU_V7 > - select ARM_GIC > - select HAVE_SMP > - select COMMON_CLK seems like you lost COMMON_CLK when moving this up, was that on purpose? -- balbi [-- Attachment #1.2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: DRA7XX: Add support for DRA7XX only build 2014-01-10 16:15 ` Felipe Balbi @ 2014-01-10 16:32 ` Tero Kristo 0 siblings, 0 replies; 8+ messages in thread From: Tero Kristo @ 2014-01-10 16:32 UTC (permalink / raw) To: balbi; +Cc: linux-omap, tony, mturquette, linux-arm-kernel On 01/10/2014 06:15 PM, Felipe Balbi wrote: > On Fri, Jan 10, 2014 at 11:57:30AM +0200, Tero Kristo wrote: >> SOC_DRA7XX was under wrong menu within Kconfig file, which prevented >> DRA7XX only build. Fixed the kconfig options for this SoC as we are >> there. voltage.c needs to be added to the DRA7XX build also, otherwise >> DRA7XX only build will fail. >> >> Signed-off-by: Tero Kristo <t-kristo@ti.com> > > one comment below, other than that: > > Reviewed-by: Felipe Balbi <balbi@ti.com> > >> --- >> arch/arm/mach-omap2/Kconfig | 18 ++++++++++-------- >> arch/arm/mach-omap2/Makefile | 1 + >> 2 files changed, 11 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig >> index dc21df1..e65948a 100644 >> --- a/arch/arm/mach-omap2/Kconfig >> +++ b/arch/arm/mach-omap2/Kconfig >> @@ -76,6 +76,16 @@ config SOC_AM43XX >> select ARM_GIC >> select MACH_OMAP_GENERIC >> >> +config SOC_DRA7XX >> + bool "TI DRA7XX" >> + depends on ARCH_MULTI_V7 >> + select ARCH_OMAP2PLUS >> + select ARM_CPU_SUSPEND if PM >> + select ARM_GIC >> + select CPU_V7 >> + select HAVE_SMP >> + select HAVE_ARM_ARCH_TIMER >> + >> config ARCH_OMAP2PLUS >> bool >> select ARCH_HAS_BANDGAP >> @@ -128,14 +138,6 @@ config SOC_HAS_REALTIME_COUNTER >> depends on SOC_OMAP5 || SOC_DRA7XX >> default y >> >> -config SOC_DRA7XX >> - bool "TI DRA7XX" >> - select ARM_ARCH_TIMER >> - select CPU_V7 >> - select ARM_GIC >> - select HAVE_SMP >> - select COMMON_CLK > > seems like you lost COMMON_CLK when moving this up, was that on purpose? > Yes. It comes through ARCH_OMAP2PLUS which is now selected. -Tero ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] ARM: DRA7XX/AM43XX build fixes 2014-01-10 9:57 [PATCH 0/2] ARM: DRA7XX/AM43XX build fixes Tero Kristo 2014-01-10 9:57 ` [PATCH 1/2] ARM: DRA7XX/AM43XX: randconfig fixes Tero Kristo 2014-01-10 9:57 ` [PATCH 2/2] ARM: DRA7XX: Add support for DRA7XX only build Tero Kristo @ 2014-01-13 16:24 ` Felipe Balbi 2014-01-13 17:13 ` Tero Kristo 2 siblings, 1 reply; 8+ messages in thread From: Felipe Balbi @ 2014-01-13 16:24 UTC (permalink / raw) To: Tero Kristo; +Cc: tony, linux-omap, mturquette, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 613 bytes --] On Fri, Jan 10, 2014 at 11:57:28AM +0200, Tero Kristo wrote: > The move of clock code from mach-omap2 to drivers/clk/ti introduces > a couple of new build errors with AM43XX/DRA7XX only builds. The > following patches address these issues by modifying the Kconfig + Makefile > under mach-omap2. > > Also, it seems DRA7XX only build is not possible at the moment, added > patch #2 to fix this. looks like we still need some extra patches since OMAP2-only builds still fail :-( Also omap1_defconfig fails miserably :-( hoping this can still get fixed in time for 3.14 :-s cheers -- balbi [-- Attachment #1.2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] ARM: DRA7XX/AM43XX build fixes 2014-01-13 16:24 ` [PATCH 0/2] ARM: DRA7XX/AM43XX build fixes Felipe Balbi @ 2014-01-13 17:13 ` Tero Kristo 0 siblings, 0 replies; 8+ messages in thread From: Tero Kristo @ 2014-01-13 17:13 UTC (permalink / raw) To: balbi; +Cc: tony, linux-omap, mturquette, linux-arm-kernel On 01/13/2014 06:24 PM, Felipe Balbi wrote: > On Fri, Jan 10, 2014 at 11:57:28AM +0200, Tero Kristo wrote: >> The move of clock code from mach-omap2 to drivers/clk/ti introduces >> a couple of new build errors with AM43XX/DRA7XX only builds. The >> following patches address these issues by modifying the Kconfig + Makefile >> under mach-omap2. >> >> Also, it seems DRA7XX only build is not possible at the moment, added >> patch #2 to fix this. > > looks like we still need some extra patches since OMAP2-only builds > still fail :-( > > Also omap1_defconfig fails miserably :-( > > hoping this can still get fixed in time for 3.14 :-s Yeah, should be simple enough to fix those... Will look at these tomorrow. Just wondering, who cares about omap1 / omap2 anyway these days? :) Basically I overlooked both with the Makefile setup I did. -Tero ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-01-13 17:13 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-01-10 9:57 [PATCH 0/2] ARM: DRA7XX/AM43XX build fixes Tero Kristo 2014-01-10 9:57 ` [PATCH 1/2] ARM: DRA7XX/AM43XX: randconfig fixes Tero Kristo 2014-01-10 16:14 ` Felipe Balbi 2014-01-10 9:57 ` [PATCH 2/2] ARM: DRA7XX: Add support for DRA7XX only build Tero Kristo 2014-01-10 16:15 ` Felipe Balbi 2014-01-10 16:32 ` Tero Kristo 2014-01-13 16:24 ` [PATCH 0/2] ARM: DRA7XX/AM43XX build fixes Felipe Balbi 2014-01-13 17:13 ` Tero Kristo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).