From: Florian Vaussard <florian.vaussard@epfl.ch>
To: Tony Lindgren <tony@atomide.com>
Cc: Tero Kristo <t-kristo@ti.com>, Kevin Hilman <khilman@linaro.org>,
kernel-build-reports@lists.linaro.org,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
Mike Turquette <mturquette@linaro.org>,
linux-omap <linux-omap@vger.kernel.org>,
Olof Johansson <olof@lixom.net>, Ash Charles <ash@gumstix.com>
Subject: Re: next boot: 34 pass, 5 fail (next-20140122)
Date: Fri, 24 Jan 2014 19:13:29 +0100 [thread overview]
Message-ID: <52E2AD49.9060301@epfl.ch> (raw)
In-Reply-To: <20140124181155.GC25488@atomide.com>
Hi,
On 01/24/2014 07:11 PM, Tony Lindgren wrote:
> * Florian Vaussard <florian.vaussard@epfl.ch> [140123 01:17]:
>>
>> I just tested next-20140123 with an OMAP3630 ES1.2 Overo/Tobi. Changing
>> the include to omap36xx.dtsi do not fix the issue. I still get the
>> external abort on non-linefetch (full log here [1]).
>
> I think the issue here is that you need to have "ti,omap36xx" in
> the compatible string in addition to including omap36xx.dtsi.
> Otherwise "ti,omap3" will initialize things for 34xx.
>
> For the initial minimal fix, I suggest we do something like the
> following. This should fix things for 36xx based tobi, then
> 34xx based tobi support can be added later on. Untested as I
> don't have one.
>
You are probably right. I will test Monday.
Regards,
Florian
> Regards,
>
> Tony
>
>
> --- a/arch/arm/boot/dts/omap3-overo.dtsi
> +++ b/arch/arm/boot/dts/omap3-overo.dtsi
> @@ -9,9 +9,6 @@
> /*
> * The Gumstix Overo must be combined with an expansion board.
> */
> -/dts-v1/;
> -
> -#include "omap34xx.dtsi"
>
> / {
> pwmleds {
> --- a/arch/arm/boot/dts/omap3-tobi.dts
> +++ b/arch/arm/boot/dts/omap3-tobi.dts
> @@ -10,11 +10,14 @@
> * Tobi expansion board is manufactured by Gumstix Inc.
> */
>
> +/dts-v1/;
> +
> +#include "omap36xx.dtsi"
> #include "omap3-overo.dtsi"
>
> / {
> model = "TI OMAP3 Gumstix Overo on Tobi";
> - compatible = "ti,omap3-tobi", "ti,omap3-overo", "ti,omap3";
> + compatible = "ti,omap3-tobi", "ti,omap3-overo", "ti,omap36xx", "ti,omap3";
>
> leds {
> compatible = "gpio-leds";
>
next prev parent reply other threads:[~2014-01-24 18:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52e06652.c103450a.79d7.6517@mx.google.com>
2014-01-23 1:35 ` next boot: 34 pass, 5 fail (next-20140122) Kevin Hilman
2014-01-23 6:23 ` Tero Kristo
2014-01-23 8:14 ` Florian Vaussard
2014-01-23 9:00 ` Tero Kristo
2014-01-23 9:15 ` Florian Vaussard
2014-01-23 9:41 ` Florian Vaussard
2014-01-23 12:27 ` Tero Kristo
2014-01-23 16:35 ` Florian Vaussard
2014-01-23 17:33 ` Nishanth Menon
2014-01-24 20:37 ` Florian Vaussard
2014-01-23 17:35 ` Tony Lindgren
2014-01-24 18:00 ` Tony Lindgren
2014-01-24 20:51 ` Florian Vaussard
2014-01-24 18:11 ` Tony Lindgren
2014-01-24 18:13 ` Florian Vaussard [this message]
2014-02-05 15:23 ` Kevin Hilman
2014-02-06 8:47 ` Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E2AD49.9060301@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=ash@gumstix.com \
--cc=kernel-build-reports@lists.linaro.org \
--cc=khilman@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).