From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balaji T K Subject: Re: [patch 1/2] mmc: omap_hsmmc: remove a duplicative test Date: Thu, 30 Jan 2014 18:29:54 +0530 Message-ID: <52EA4CCA.5010904@ti.com> References: <20140130121518.GA10368@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:34624 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbaA3NAJ (ORCPT ); Thu, 30 Jan 2014 08:00:09 -0500 In-Reply-To: <20140130121518.GA10368@elgon.mountain> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Dan Carpenter Cc: Chris Ball , linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, kernel-janitors@vger.kernel.org On Thursday 30 January 2014 05:45 PM, Dan Carpenter wrote: > Static checkers complain that testing for both "next" and "!next" is > duplicative. > > Signed-off-by: Dan Carpenter > Looks good to me Acked-by: Balaji T K > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 2a629fbde613..bfb0dbd052c0 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -1235,8 +1235,7 @@ static int omap_hsmmc_pre_dma_transfer(struct omap_hsmmc_host *host, > } > > /* Check if next job is already prepared */ > - if (next || > - (!next && data->host_cookie != host->next_data.cookie)) { > + if (next || data->host_cookie != host->next_data.cookie) { > dma_len = dma_map_sg(chan->device->dev, data->sg, data->sg_len, > omap_hsmmc_get_dma_dir(host, data)); > >