* [patch 1/2] mmc: omap_hsmmc: remove a duplicative test
@ 2014-01-30 12:15 Dan Carpenter
2014-01-30 12:59 ` Balaji T K
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-01-30 12:15 UTC (permalink / raw)
To: Balaji T K; +Cc: Chris Ball, linux-mmc, linux-omap, kernel-janitors
Static checkers complain that testing for both "next" and "!next" is
duplicative.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 2a629fbde613..bfb0dbd052c0 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1235,8 +1235,7 @@ static int omap_hsmmc_pre_dma_transfer(struct omap_hsmmc_host *host,
}
/* Check if next job is already prepared */
- if (next ||
- (!next && data->host_cookie != host->next_data.cookie)) {
+ if (next || data->host_cookie != host->next_data.cookie) {
dma_len = dma_map_sg(chan->device->dev, data->sg, data->sg_len,
omap_hsmmc_get_dma_dir(host, data));
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch 1/2] mmc: omap_hsmmc: remove a duplicative test
2014-01-30 12:15 [patch 1/2] mmc: omap_hsmmc: remove a duplicative test Dan Carpenter
@ 2014-01-30 12:59 ` Balaji T K
0 siblings, 0 replies; 2+ messages in thread
From: Balaji T K @ 2014-01-30 12:59 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Chris Ball, linux-mmc, linux-omap, kernel-janitors
On Thursday 30 January 2014 05:45 PM, Dan Carpenter wrote:
> Static checkers complain that testing for both "next" and "!next" is
> duplicative.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Looks good to me
Acked-by: Balaji T K <balajitk@ti.com>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 2a629fbde613..bfb0dbd052c0 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1235,8 +1235,7 @@ static int omap_hsmmc_pre_dma_transfer(struct omap_hsmmc_host *host,
> }
>
> /* Check if next job is already prepared */
> - if (next ||
> - (!next && data->host_cookie != host->next_data.cookie)) {
> + if (next || data->host_cookie != host->next_data.cookie) {
> dma_len = dma_map_sg(chan->device->dev, data->sg, data->sg_len,
> omap_hsmmc_get_dma_dir(host, data));
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-30 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-30 12:15 [patch 1/2] mmc: omap_hsmmc: remove a duplicative test Dan Carpenter
2014-01-30 12:59 ` Balaji T K
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).