[PATCH] mtd:elm: Use correct check on return value of pm_runtime_get_sync

[PATCH] mtd:elm: Use correct check on return value of pm_runtime_get_sync

[Stefan Sørensen]

The ELM driver incorrectly reagard any non-zero return value from
pm_runtime_get_sync as an error, but it may return 1 if the device
was already active. Fix to only error when return value is negative.

Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
---
 drivers/mtd/devices/elm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
index d1dd6a3..e2c073c 100644
--- a/drivers/mtd/devices/elm.c
+++ b/drivers/mtd/devices/elm.c
@@ -380,7 +380,7 @@ static int elm_probe(struct platform_device *pdev)
 	}
 
 	pm_runtime_enable(&pdev->dev);
-	if (pm_runtime_get_sync(&pdev->dev)) {
+	if (pm_runtime_get_sync(&pdev->dev) < 0) {
 		ret = -EINVAL;
 		pm_runtime_disable(&pdev->dev);
 		dev_err(&pdev->dev, "can't enable clock\n");
-- 
1.8.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mtd:elm: Use correct check on return value of pm_runtime_get_sync

[Nishanth Menon]

-avinash
On 02/05/2014 07:42 AM, Stefan Sørensen wrote:
> The ELM driver incorrectly reagard any non-zero return value from
> pm_runtime_get_sync as an error, but it may return 1 if the device
> was already active. Fix to only error when return value is negative.
> 
> Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
> ---
>  drivers/mtd/devices/elm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
> index d1dd6a3..e2c073c 100644
> --- a/drivers/mtd/devices/elm.c
> +++ b/drivers/mtd/devices/elm.c
> @@ -380,7 +380,7 @@ static int elm_probe(struct platform_device *pdev)
>  	}
>  
>  	pm_runtime_enable(&pdev->dev);
> -	if (pm_runtime_get_sync(&pdev->dev)) {
> +	if (pm_runtime_get_sync(&pdev->dev) < 0) {
>  		ret = -EINVAL;
>  		pm_runtime_disable(&pdev->dev);
>  		dev_err(&pdev->dev, "can't enable clock\n");
> 

Though unrelated to specifically this, elm_resume has a get_sync
without error check..

Further, you might want to cc the mailing lists generated by
./scripts/get_maintainer.pl

-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html