From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH 2/3] ARM: OMAP2+: AM43x: Add ID for ES1.1 Date: Thu, 6 Feb 2014 08:38:44 -0600 Message-ID: <52F39E74.3030404@ti.com> References: <1391676348-32339-1-git-send-email-lokeshvutla@ti.com> <1391676348-32339-3-git-send-email-lokeshvutla@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:33007 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbaBFOjP (ORCPT ); Thu, 6 Feb 2014 09:39:15 -0500 In-Reply-To: <1391676348-32339-3-git-send-email-lokeshvutla@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Lokesh Vutla , linux-omap@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, tony@atomide.com, linux@arm.linux.org.uk, rnayak@ti.com, nsekhar@ti.com On 02/06/2014 02:45 AM, Lokesh Vutla wrote: > Adding ID for AM437x ES1.1 silicon. > > Signed-off-by: Lokesh Vutla > --- > arch/arm/mach-omap2/id.c | 14 ++++++++++++-- > arch/arm/mach-omap2/soc.h | 3 ++- > 2 files changed, 14 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c > index 9428c5f..8a05eaf 100644 > --- a/arch/arm/mach-omap2/id.c > +++ b/arch/arm/mach-omap2/id.c > @@ -465,8 +465,18 @@ void __init omap3xxx_check_revision(void) > } > break; > case 0xb98c: > - omap_revision = AM437X_REV_ES1_0; > - cpu_rev = "1.0"; > + switch (rev) { > + case 0: > + omap_revision = AM437X_REV_ES1_0; > + cpu_rev = "1.0"; > + break; > + case 1: > + /* FALLTHROUGH */ > + default: > + omap_revision = AM437X_REV_ES1_1; > + cpu_rev = "1.1"; > + break; > + } > break; > case 0xb8f2: > switch (rev) { > diff --git a/arch/arm/mach-omap2/soc.h b/arch/arm/mach-omap2/soc.h > index 076bd90..30abcc8 100644 > --- a/arch/arm/mach-omap2/soc.h > +++ b/arch/arm/mach-omap2/soc.h > @@ -438,7 +438,8 @@ IS_OMAP_TYPE(3430, 0x3430) > #define AM335X_REV_ES2_1 (AM335X_CLASS | (0x2 << 8)) > > #define AM437X_CLASS 0x43700000 > -#define AM437X_REV_ES1_0 AM437X_CLASS > +#define AM437X_REV_ES1_0 (AM437X_CLASS | (0x10 << 8)) > +#define AM437X_REV_ES1_1 (AM437X_CLASS | (0x11 << 8)) > > #define OMAP443X_CLASS 0x44300044 > #define OMAP4430_REV_ES1_0 (OMAP443X_CLASS | (0x10 << 8)) > can you also check if socbus shows proper results? I had http://slexy.org/view/s20e3OsIVx with v3.14-rc1 -- Regards, Nishanth Menon