* [PATCH] ARM: dts: OMAP5: add pmu node
@ 2014-01-29 16:56 Nathan Lynch
2014-02-11 20:14 ` Nathan Lynch
0 siblings, 1 reply; 4+ messages in thread
From: Nathan Lynch @ 2014-01-29 16:56 UTC (permalink / raw)
To: linux-omap; +Cc: devicetree, linux-arm-kernel
Expose the PMU on OMAP5.
Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
---
Notes:
Briefly tested with perf on OMAP5 UEVM with next-20140124.
arch/arm/boot/dts/omap5.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index a72813a9663e..fbf4661436e2 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -76,6 +76,12 @@
<GIC_PPI 10 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_LOW)>;
};
+ pmu {
+ compatible = "arm,cortex-a15-pmu";
+ interrupts = <0 131 4>,
+ <0 132 4>;
+ };
+
gic: interrupt-controller@48211000 {
compatible = "arm,cortex-a15-gic";
interrupt-controller;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: OMAP5: add pmu node
2014-01-29 16:56 [PATCH] ARM: dts: OMAP5: add pmu node Nathan Lynch
@ 2014-02-11 20:14 ` Nathan Lynch
2014-02-12 13:00 ` Benoit Cousson
0 siblings, 1 reply; 4+ messages in thread
From: Nathan Lynch @ 2014-02-11 20:14 UTC (permalink / raw)
To: linux-omap; +Cc: bcousson, tony
On 01/29/2014 10:56 AM, Nathan Lynch wrote:
> Expose the PMU on OMAP5.
>
> Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
OMAP folks, any issues with this patch?
> ---
>
> Notes:
> Briefly tested with perf on OMAP5 UEVM with next-20140124.
>
> arch/arm/boot/dts/omap5.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index a72813a9663e..fbf4661436e2 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -76,6 +76,12 @@
> <GIC_PPI 10 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_LOW)>;
> };
>
> + pmu {
> + compatible = "arm,cortex-a15-pmu";
> + interrupts = <0 131 4>,
> + <0 132 4>;
> + };
> +
> gic: interrupt-controller@48211000 {
> compatible = "arm,cortex-a15-gic";
> interrupt-controller;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: OMAP5: add pmu node
2014-02-11 20:14 ` Nathan Lynch
@ 2014-02-12 13:00 ` Benoit Cousson
2014-02-12 15:02 ` Nathan Lynch
0 siblings, 1 reply; 4+ messages in thread
From: Benoit Cousson @ 2014-02-12 13:00 UTC (permalink / raw)
To: Nathan Lynch, linux-omap; +Cc: tony
Hi Nathan,
On 11/02/2014 21:14, Nathan Lynch wrote:
> On 01/29/2014 10:56 AM, Nathan Lynch wrote:
>> Expose the PMU on OMAP5.
>>
>> Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
>
> OMAP folks, any issues with this patch?
Yes :-)
>> Notes:
>> Briefly tested with perf on OMAP5 UEVM with next-20140124.
>>
>> arch/arm/boot/dts/omap5.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
>> index a72813a9663e..fbf4661436e2 100644
>> --- a/arch/arm/boot/dts/omap5.dtsi
>> +++ b/arch/arm/boot/dts/omap5.dtsi
>> @@ -76,6 +76,12 @@
>> <GIC_PPI 10 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_LOW)>;
>> };
>>
>> + pmu {
>> + compatible = "arm,cortex-a15-pmu";
>> + interrupts = <0 131 4>,
>> + <0 132 4>;
Could you use the macros instead of hard coded value? You have the
example just before your modification in the patch itself.
Thanks,
Benoit
--
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: OMAP5: add pmu node
2014-02-12 13:00 ` Benoit Cousson
@ 2014-02-12 15:02 ` Nathan Lynch
0 siblings, 0 replies; 4+ messages in thread
From: Nathan Lynch @ 2014-02-12 15:02 UTC (permalink / raw)
To: Benoit Cousson, linux-omap; +Cc: tony
On 02/12/2014 07:00 AM, Benoit Cousson wrote:
>> On 01/29/2014 10:56 AM, Nathan Lynch wrote:
>>> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
>>> index a72813a9663e..fbf4661436e2 100644
>>> --- a/arch/arm/boot/dts/omap5.dtsi
>>> +++ b/arch/arm/boot/dts/omap5.dtsi
>>> @@ -76,6 +76,12 @@
>>> <GIC_PPI 10 (GIC_CPU_MASK_RAW(3) |
>>> IRQ_TYPE_LEVEL_LOW)>;
>>> };
>>>
>>> + pmu {
>>> + compatible = "arm,cortex-a15-pmu";
>>> + interrupts = <0 131 4>,
>>> + <0 132 4>;
>
> Could you use the macros instead of hard coded value? You have the
> example just before your modification in the patch itself.
Thanks Benoit. Sorry for missing that, will fix.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-12 15:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-29 16:56 [PATCH] ARM: dts: OMAP5: add pmu node Nathan Lynch
2014-02-11 20:14 ` Nathan Lynch
2014-02-12 13:00 ` Benoit Cousson
2014-02-12 15:02 ` Nathan Lynch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).