Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR

Md Danish Anwar
2023-03-17T05:03:00Z

On 16/03/23 19:34, Roger Quadros wrote:
>
> Hi,
>
> On 16/03/2023 15:11, Md Danish Anwar wrote:
>>
>>
>> On 16/03/23 17:49, Roger Quadros wrote:
>>>
>>>
>>> On 16/03/2023 13:44, Md Danish Anwar wrote:
>>>>
>>>> On 16/03/23 17:06, Roger Quadros wrote:
>>>>> Hi,
>>>>>
>>>>> On 16/03/2023 13:05, Md Danish Anwar wrote:
>>>>>> Hi Roger,
>>>>>>
>>>>>> On 15/03/23 17:52, Roger Quadros wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 13/03/2023 13:11, MD Danish Anwar wrote:
>>>>>>>> From: Suman Anna <s-anna@ti.com>
>

[..]

>> Sure, then I will use the existing enum pru_type.
>>
>> The enum pru_type is currently in drivers/remoteproc/pruss.c I will move this
>> enum definition from there to include/linux/remoteproc/pruss.h
>
> There are 2 public pruss.h files.
> include/linux/remoteproc/pruss.h
> and
> include/linux/pruss_driver.h
>
> Why is that and when to use what?
>

The include/linux/remoteproc/pruss.h file was introduced in series [1] as a
public header file for PRU_RPROC driver (drivers/remoteproc/pru_rproc.c)

The second header file include/linux/pruss_driver.h was introduced much earlier
as part of [2] , "soc: ti: pruss: Add a platform driver for PRUSS in TI SoCs".

As far as I can see, seems like pruss_driver.h was added as a public header
file for PRUSS platform driver (drivers/soc/ti/pruss.c)

[1] https://lore.kernel.org/all/20230106121046.886863-1-danishanwar@ti.com/
[2] https://lore.kernel.org/all/1542886753-17625-7-git-send-email-rogerq@ti.com/

> cheers,
> -roger

--
Thanks and Regards,
Danish.