From: Florian Vaussard <florian.vaussard@epfl.ch>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>, Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 0/3] mfd: twl6040: Updates for i2s speed and fix for chip deadlock
Date: Thu, 27 Feb 2014 16:11:21 +0100 [thread overview]
Message-ID: <530F5599.2060100@epfl.ch> (raw)
In-Reply-To: <1393509410-1640-1-git-send-email-peter.ujfalusi@ti.com>
Hi Peter,
On 02/27/2014 02:56 PM, Peter Ujfalusi wrote:
> Hi,
>
> While looking into a report by Florian Vaussard [1] I have noticed couple of most
> likely unrelated issues:
> - all boards using twl6040 configures the i2c bus to 400KHz while twl6040 is set
> to 100KHz as default.
> - if I set the audpwron GPIO high [2] in the bootloader the i2c communication towards
> twl6040 will be broken
>
> The solution or these are:
> set the twl6040 to i2c fast mode with regmap patch
> Clear the INTID register right after we request the audpwron GPIO and set it to
> low.
>
> Generated on top of:
> git://git.linaro.org/people/lee.jones/mfd.git for-mfd-next
>
> Tested on PandaBoard, PandaBoardES, OMAP4-blaze (SDP)
>
> [1] http://www.spinics.net/lists/arm-kernel/msg310725.html
> [2] Command in u-boot to enable the audpwron on PandaBoards: gpio set 127
>
> Regards,
> Peter
> ---
> Peter Ujfalusi (3):
> mfd: twl6040: Select i2c fast mode as default with regmap patch
> mfd: twl6040: Move register patching earlier in probe
> mfd: twl6040: Clear the interrupt ID register before requesting IRQ
Patch 3 is making my system to boot normally.
Now, it is hard to devise if this is the root cause of the problem that
I was experiencing, since adding a sleep at the exact same place was
fixing my issue. Your twl6040_reg_read() could have the same effect,
without solving directly the issue.
Anyway, I tested your series on DuoVero.
Tested-by: Florian Vaussard <florian.vaussard@epfl.ch>
Regards,
Florian
prev parent reply other threads:[~2014-02-27 15:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 13:56 [PATCH 0/3] mfd: twl6040: Updates for i2s speed and fix for chip deadlock Peter Ujfalusi
2014-02-27 13:56 ` [PATCH 1/3] mfd: twl6040: Select i2c fast mode as default with regmap patch Peter Ujfalusi
2014-02-27 14:24 ` Nishanth Menon
2014-02-27 14:33 ` Peter Ujfalusi
2014-02-27 15:00 ` Nishanth Menon
2014-02-28 7:39 ` Peter Ujfalusi
2014-02-28 13:30 ` Nishanth Menon
2014-02-28 14:26 ` Peter Ujfalusi
2014-02-28 15:07 ` Nishanth Menon
2014-03-03 11:30 ` Peter Ujfalusi
2014-02-27 13:56 ` [PATCH 2/3] mfd: twl6040: Move register patching earlier in probe Peter Ujfalusi
2014-02-27 13:56 ` [PATCH 3/3] mfd: twl6040: Clear the interrupt ID register before requesting IRQ Peter Ujfalusi
2014-02-27 15:11 ` Florian Vaussard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530F5599.2060100@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).