From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver Date: Fri, 7 Mar 2014 19:17:29 +0530 Message-ID: <5319CDF1.4030405@ti.com> References: <1393832008-22174-1-git-send-email-archit@ti.com> <1393922965-15967-1-git-send-email-archit@ti.com> <1393922965-15967-8-git-send-email-archit@ti.com> <53159F7D.8020707@xs4all.nl> <5315B822.7010005@ti.com> <5315BA83.5080500@xs4all.nl> <5319B26B.8050900@ti.com> <5319C2A7.6090805@xs4all.nl> <5319C813.5030508@ti.com> <5319CA53.9020101@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:60722 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbaCGNsG (ORCPT ); Fri, 7 Mar 2014 08:48:06 -0500 In-Reply-To: <5319CA53.9020101@xs4all.nl> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Hans Verkuil Cc: k.debski@samsung.com, linux-media@vger.kernel.org, linux-omap@vger.kernel.org On Friday 07 March 2014 07:02 PM, Hans Verkuil wrote: > On 03/07/2014 02:22 PM, Archit Taneja wrote: >> Hi, >> >> On Friday 07 March 2014 06:29 PM, Hans Verkuil wrote: >>>> >>>> Do you think I can go ahead with posting the v3 patch set for 3.15, and >>>> work on fixing the compliance issue for the -rc fixes? >>> >>> It's fine to upstream this in staging, but while not all compliance errors >>> are fixed it can't go to drivers/media. I'm tightening the screws on that >>> since v4l2-compliance is getting to be such a powerful tool for ensuring >>> the driver complies. >>> >> >> But the vpe driver is already in drivers/media. How do I push these >> patches if the vpe drivers is not in staging? > > Oops, sorry. I got confused with Benoit's AM437x ti-vpfe patch :-) > > Disregard what I said, it's OK to upstream it. But if you could just spend > some hours fixing the problems, that would really be best. Sure, I'll try to fix these issues and then post a v3. > >> >> >> >>>> Multiplanar: TRY_FMT(G_FMT) != G_FMT >>>> test VIDIOC_TRY_FMT: FAIL >>>> warn: v4l2-test-formats.cpp(834): S_FMT cannot handle >>>> an invalid pixelformat. >>>> warn: v4l2-test-formats.cpp(835): This may or may not >>>> be a problem. For more information see: >>>> warn: v4l2-test-formats.cpp(836): >>>> http://www.mail-archive.com/linux-media@vger.kernel.org/msg56550.html >>>> fail: v4l2-test-formats.cpp(420): pix_mp.reserved not >>>> zeroed >>> >>> This is easy enough to fix. >>> >>>> fail: v4l2-test-formats.cpp(851): Video Capture >>>> Multiplanar is valid, but no S_FMT was implemented >>> >>> For the FMT things: run with -T: that gives nice traces. You can also >>> set the debug flag: echo 2 >/sys/class/video4linux/video0/debug to see all >>> ioctls in more detail. >> >> Thanks for the tip, will try this. >> >>> >>>> test VIDIOC_S_FMT: FAIL >>>> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) >>>> >>>> Codec ioctls: >>>> test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) >>>> test VIDIOC_G_ENC_INDEX: OK (Not Supported) >>>> test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) >>>> >>>> Buffer ioctls: >>>> info: test buftype Video Capture Multiplanar >>>> warn: v4l2-test-buffers.cpp(403): VIDIOC_CREATE_BUFS >>>> not supported >>>> info: test buftype Video Output Multiplanar >>>> warn: v4l2-test-buffers.cpp(403): VIDIOC_CREATE_BUFS >>>> not supported >>>> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK >>>> test VIDIOC_EXPBUF: OK (Not Supported) >>>> test read/write: OK (Not Supported) >>>> Video Capture Multiplanar (polling): >>>> Buffer: 0 Sequence: 0 Field: Top Timestamp: 113.178208s >>>> fail: v4l2-test-buffers.cpp(222): buf.field != >>>> cur_fmt.fmt.pix.field >>> >>> Definitely needs to be fixed, you probably just don't set the field at all. >> >> The VPE output is always progressive. But yes, I should still set the >> field parameter to something. > > V4L2_FIELD_NONE is the correct field setting for that. I checked the driver, it isn't setting it to V4L2_FIELD_NONE. Will fix this. Archit