From: Kishon Vijay Abraham I <kishon@ti.com>
To: balbi@ti.com
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v6] phy: omap-usb2: move omap_usb.h from linux/usb/ to linux/phy/
Date: Fri, 7 Mar 2014 23:09:02 +0530 [thread overview]
Message-ID: <531A0436.3080201@ti.com> (raw)
In-Reply-To: <20140307165043.GC23885@saruman.home>
On Friday 07 March 2014 10:20 PM, Felipe Balbi wrote:
> On Fri, Mar 07, 2014 at 10:18:08PM +0530, Kishon Vijay Abraham I wrote:
>> No functional change. Moved omap_usb.h from linux/usb/ to linux/phy/.
>> Also removed the unused members of struct omap_usb (after phy-omap-pipe3
>> started using it's own header file)
>
> does this depend in any other patch ? I get the following when applying
> *only* this patch on top of v3.14-rc5:
yeah.. this is for linux-phy tree. I'll take this patch.
Thanks
Kishon
>
> drivers/phy/phy-omap-usb2.c: In function ‘omap_usb2_suspend’:
> drivers/phy/phy-omap-usb2.c:106:21: error: ‘struct omap_usb’ has no member named ‘is_suspended’
> if (suspend && !phy->is_suspended) {
> ^
> drivers/phy/phy-omap-usb2.c:109:6: error: ‘struct omap_usb’ has no member named ‘is_suspended’
> phy->is_suspended = 1;
> ^
> drivers/phy/phy-omap-usb2.c:110:28: error: ‘struct omap_usb’ has no member named ‘is_suspended’
> } else if (!suspend && phy->is_suspended) {
> ^
> drivers/phy/phy-omap-usb2.c:117:6: error: ‘struct omap_usb’ has no member named ‘is_suspended’
> phy->is_suspended = 0;
> ^
> drivers/phy/phy-omap-usb2.c: In function ‘omap_usb2_probe’:
> drivers/phy/phy-omap-usb2.c:194:5: error: ‘struct omap_usb’ has no member named ‘is_suspended’
> phy->is_suspended = 1;
> ^
> make[1]: *** [drivers/phy/phy-omap-usb2.o] Error 1
> make: *** [drivers/phy/] Error 2
> make: *** Waiting for unfinished jobs....
> CC [M] drivers/usb/phy/phy-mxs-usb.o
> drivers/usb/phy/phy-omap-usb3.c:22:32: fatal error: linux/usb/omap_usb.h: No such file or directory
> #include <linux/usb/omap_usb.h>
> ^
> compilation terminated.
> make[1]: *** [drivers/usb/phy/phy-omap-usb3.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [drivers/usb/phy/] Error 2
>
next prev parent reply other threads:[~2014-03-07 17:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 11:38 [PATCH v5 0/6] Make dwc3 use Generic PHY Framework Kishon Vijay Abraham I
2014-03-03 11:38 ` [PATCH v5 1/6] usb: dwc3: core: support optional PHYs Kishon Vijay Abraham I
2014-03-03 11:38 ` [PATCH v5 2/6] usb: dwc3: adapt dwc3 core to use Generic PHY Framework Kishon Vijay Abraham I
2014-03-05 14:43 ` Roger Quadros
2014-03-05 14:47 ` Kishon Vijay Abraham I
2014-03-05 15:24 ` Roger Quadros
2014-03-03 11:38 ` [PATCH v5 3/6] drivers: phy: usb3/pipe3: Adapt pipe3 driver to " Kishon Vijay Abraham I
2014-03-06 9:30 ` Kishon Vijay Abraham I
2014-03-03 11:38 ` [PATCH v5 4/6] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2 Kishon Vijay Abraham I
2014-03-03 11:38 ` [PATCH v5 5/6] phy: omap-usb2: move omap_usb.h from linux/usb/ to linux/phy/ Kishon Vijay Abraham I
2014-03-03 11:38 ` [PATCH v5 6/6] arm/dts: added dt properties to adapt to the new phy framwork Kishon Vijay Abraham I
2014-03-05 12:42 ` Kishon Vijay Abraham I
[not found] ` <53171BC9.8050808-l0cyMroinI0@public.gmane.org>
2014-03-05 19:40 ` Tony Lindgren
2014-03-03 12:21 ` [PATCH v5 0/6] Make dwc3 use Generic PHY Framework Roger Quadros
2014-03-03 12:36 ` Kishon Vijay Abraham I
[not found] ` <1393846695-14644-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2014-03-03 16:40 ` Felipe Balbi
2014-03-04 13:31 ` Kishon Vijay Abraham I
2014-03-07 16:48 ` [PATCH v6] phy: omap-usb2: move omap_usb.h from linux/usb/ to linux/phy/ Kishon Vijay Abraham I
2014-03-07 16:50 ` Felipe Balbi
2014-03-07 17:39 ` Kishon Vijay Abraham I [this message]
2014-03-07 17:40 ` Felipe Balbi
2014-03-07 17:46 ` Kishon Vijay Abraham I
2014-03-07 18:08 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531A0436.3080201@ti.com \
--to=kishon@ti.com \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).