From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH] mfd: twl-core: Fix accessibility of some twl4030 audio registers Date: Tue, 11 Mar 2014 10:29:53 +0200 Message-ID: <531EC981.8090806@ti.com> References: <20140310191250.34f1410e@tomas.local.tbs-biometrics.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:48535 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753087AbaCKIa2 (ORCPT ); Tue, 11 Mar 2014 04:30:28 -0400 In-Reply-To: <20140310191250.34f1410e@tomas.local.tbs-biometrics.cz> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tomas Novotny , linux-omap@vger.kernel.org On 03/10/2014 08:12 PM, Tomas Novotny wrote: > There are some unused registers in twl4030 at I2C address 0x49 and function > twl4030_49_nop_reg() is used to check accessibility of that registers. These > registers are written in decimal format but the values are correct in > hexadecimal format. (It can be checked few lines above the patched code - > these registers are marked as unused there.) > > As a consequence three registers of audio submodule are treated as > inaccessible (preamplifier carkit right and both handsfree registers). > > CC: Peter Ujfalusi > Signed-off-by: Tomas Novotny > --- > drivers/mfd/twl-core.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c > index ed71832..e87140b 100644 > --- a/drivers/mfd/twl-core.c > +++ b/drivers/mfd/twl-core.c > @@ -282,11 +282,11 @@ static struct reg_default twl4030_49_defaults[] = { > static bool twl4030_49_nop_reg(struct device *dev, unsigned int reg) > { > switch (reg) { > - case 0: > - case 3: > - case 40: > - case 41: > - case 42: > + case 0x00: > + case 0x03: > + case 0x40: > + case 0x41: > + case 0x42: Uhm, I can not be that @#$%^& that I did this... I have no idea how I left out the "0x" Thanks for spotting it! Acked-by Peter Ujfalusi