From: Florian Vaussard <florian.vaussard@epfl.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>,
Tony Lindgren <tony@atomide.com>,
Benoit Cousson <bcousson@baylibre.com>
Cc: Ash Charles <ash@gumstix.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: overo: Add support for DVI output
Date: Thu, 13 Mar 2014 09:25:43 +0100 [thread overview]
Message-ID: <53216B87.9070007@epfl.ch> (raw)
In-Reply-To: <53200894.5020602@ti.com>
Hi,
On 03/12/2014 08:11 AM, Tomi Valkeinen wrote:
> On 11/03/14 14:34, Florian Vaussard wrote:
>> Summit and Tobi expansion boards have a HDMI connector with a TFP410
>> encoder. Add a common include file for this configuration, and then
>> use it for Summit and Tobi.
>>
>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
>> ---
>> arch/arm/boot/dts/omap3-overo-common-dvi.dtsi | 109 +++++++++++++++++++++++
>> arch/arm/boot/dts/omap3-overo-summit-common.dtsi | 1 +
>> arch/arm/boot/dts/omap3-overo-tobi-common.dtsi | 1 +
>> 3 files changed, 111 insertions(+)
>> create mode 100644 arch/arm/boot/dts/omap3-overo-common-dvi.dtsi
>
> <snip>
>
>> +&dss {
>> + status = "ok";
>> +
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&dss_dpi_pins
>> + &i2c3_pins>;
>
> The i2c3 pins don't belong here, they are not related to dss. The
> dvi-connector uses i2c3, but I don't think they belong there either, as
> the i2c3 bus can be used by multiple devices. So I guess they should be
> set in &i2c3 node.
>
You are right. And as I am already using i2c3 for other things, this
duplicates the pinctrl. I will drop it.
Regards,
Florian
next prev parent reply other threads:[~2014-03-13 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 12:34 [PATCH 0/3] ARM: dts: overo: Add graphics output Florian Vaussard
2014-03-11 12:34 ` [PATCH 1/3] ARM: dts: overo: Add support for DVI output Florian Vaussard
2014-03-12 7:11 ` Tomi Valkeinen
2014-03-13 8:25 ` Florian Vaussard [this message]
2014-03-11 12:34 ` [PATCH 2/3] ARM: dts: overo: Add support for 4.3'' LCD output Florian Vaussard
2014-03-11 12:34 ` [PATCH 3/3] ARM: dts: overo: Add support for 3.5'' " Florian Vaussard
2014-03-12 7:14 ` [PATCH 0/3] ARM: dts: overo: Add graphics output Tomi Valkeinen
2014-03-13 8:24 ` Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53216B87.9070007@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=ash@gumstix.com \
--cc=bcousson@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).