* [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot
@ 2014-04-08 20:51 Sebastian Reichel
2014-04-08 21:40 ` Aaro Koskinen
2014-04-09 6:27 ` Tomi Valkeinen
0 siblings, 2 replies; 6+ messages in thread
From: Sebastian Reichel @ 2014-04-08 20:51 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Tomi Valkeinen, linux-omap, Sebastian Reichel
Do not try to initialize display for DT boot, since omapdss
is now initialized via Device Tree. Without this patch the
display subsystem does not properly come up.
Signed-off-by: Sebastian Reichel <sre@kernel.org>
---
Hi,
This patch should be added to 3.15-rc to make display initialization via DT
possible. Sorry for not noticing earlier, that this was missing in Tomi's
patchset.
-- Sebastian
---
arch/arm/mach-omap2/board-rx51-video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/board-rx51-video.c b/arch/arm/mach-omap2/board-rx51-video.c
index 43a90c8..9cfebc5 100644
--- a/arch/arm/mach-omap2/board-rx51-video.c
+++ b/arch/arm/mach-omap2/board-rx51-video.c
@@ -48,7 +48,7 @@ static struct omap_dss_board_info rx51_dss_board_info = {
static int __init rx51_video_init(void)
{
- if (!machine_is_nokia_rx51() && !of_machine_is_compatible("nokia,omap3-n900"))
+ if (!machine_is_nokia_rx51())
return 0;
if (omap_mux_init_gpio(RX51_LCD_RESET_GPIO, OMAP_PIN_OUTPUT)) {
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot
2014-04-08 20:51 [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot Sebastian Reichel
@ 2014-04-08 21:40 ` Aaro Koskinen
2014-04-08 22:23 ` Tony Lindgren
2014-04-09 6:27 ` Tomi Valkeinen
1 sibling, 1 reply; 6+ messages in thread
From: Aaro Koskinen @ 2014-04-08 21:40 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: Tony Lindgren, Tomi Valkeinen, linux-omap
Hi,
On Tue, Apr 08, 2014 at 10:51:18PM +0200, Sebastian Reichel wrote:
> Do not try to initialize display for DT boot, since omapdss
> is now initialized via Device Tree. Without this patch the
> display subsystem does not properly come up.
>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
> Hi,
>
> This patch should be added to 3.15-rc to make display initialization via DT
> possible. Sorry for not noticing earlier, that this was missing in Tomi's
> patchset.
>
> -- Sebastian
> ---
> arch/arm/mach-omap2/board-rx51-video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-video.c b/arch/arm/mach-omap2/board-rx51-video.c
> index 43a90c8..9cfebc5 100644
> --- a/arch/arm/mach-omap2/board-rx51-video.c
> +++ b/arch/arm/mach-omap2/board-rx51-video.c
> @@ -48,7 +48,7 @@ static struct omap_dss_board_info rx51_dss_board_info = {
>
> static int __init rx51_video_init(void)
> {
> - if (!machine_is_nokia_rx51() && !of_machine_is_compatible("nokia,omap3-n900"))
> + if (!machine_is_nokia_rx51())
> return 0;
Shouldn't we delete the whole file, since non-DT boot is
not anymore supported?
A.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot
2014-04-08 21:40 ` Aaro Koskinen
@ 2014-04-08 22:23 ` Tony Lindgren
2014-04-08 23:09 ` Aaro Koskinen
0 siblings, 1 reply; 6+ messages in thread
From: Tony Lindgren @ 2014-04-08 22:23 UTC (permalink / raw)
To: Aaro Koskinen; +Cc: Sebastian Reichel, Tomi Valkeinen, linux-omap
* Aaro Koskinen <aaro.koskinen@iki.fi> [140408 14:48]:
> Hi,
>
> On Tue, Apr 08, 2014 at 10:51:18PM +0200, Sebastian Reichel wrote:
> > Do not try to initialize display for DT boot, since omapdss
> > is now initialized via Device Tree. Without this patch the
> > display subsystem does not properly come up.
> >
> > Signed-off-by: Sebastian Reichel <sre@kernel.org>
> > ---
> > Hi,
> >
> > This patch should be added to 3.15-rc to make display initialization via DT
> > possible. Sorry for not noticing earlier, that this was missing in Tomi's
> > patchset.
> >
> > -- Sebastian
> > ---
> > arch/arm/mach-omap2/board-rx51-video.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-omap2/board-rx51-video.c b/arch/arm/mach-omap2/board-rx51-video.c
> > index 43a90c8..9cfebc5 100644
> > --- a/arch/arm/mach-omap2/board-rx51-video.c
> > +++ b/arch/arm/mach-omap2/board-rx51-video.c
> > @@ -48,7 +48,7 @@ static struct omap_dss_board_info rx51_dss_board_info = {
> >
> > static int __init rx51_video_init(void)
> > {
> > - if (!machine_is_nokia_rx51() && !of_machine_is_compatible("nokia,omap3-n900"))
> > + if (!machine_is_nokia_rx51())
> > return 0;
>
> Shouldn't we delete the whole file, since non-DT boot is
> not anymore supported?
Legacy support is still there for omap3 until the DSS displays are
converted.
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot
2014-04-08 22:23 ` Tony Lindgren
@ 2014-04-08 23:09 ` Aaro Koskinen
0 siblings, 0 replies; 6+ messages in thread
From: Aaro Koskinen @ 2014-04-08 23:09 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Sebastian Reichel, Tomi Valkeinen, linux-omap
On Tue, Apr 08, 2014 at 03:23:55PM -0700, Tony Lindgren wrote:
> * Aaro Koskinen <aaro.koskinen@iki.fi> [140408 14:48]:
> > Shouldn't we delete the whole file, since non-DT boot is
> > not anymore supported?
>
> Legacy support is still there for omap3 until the DSS displays are
> converted.
Sorry, I was confused. It seems on omap2 (N800 etc.) the legacy boot
is not supported anymore, and I thought it's the same for omap3. Sorry
for the noise.
A.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot
2014-04-08 20:51 [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot Sebastian Reichel
2014-04-08 21:40 ` Aaro Koskinen
@ 2014-04-09 6:27 ` Tomi Valkeinen
2014-04-18 22:43 ` Tony Lindgren
1 sibling, 1 reply; 6+ messages in thread
From: Tomi Valkeinen @ 2014-04-09 6:27 UTC (permalink / raw)
To: Sebastian Reichel, Tony Lindgren; +Cc: linux-omap
[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]
On 08/04/14 23:51, Sebastian Reichel wrote:
> Do not try to initialize display for DT boot, since omapdss
> is now initialized via Device Tree. Without this patch the
> display subsystem does not properly come up.
>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
> Hi,
>
> This patch should be added to 3.15-rc to make display initialization via DT
> possible. Sorry for not noticing earlier, that this was missing in Tomi's
> patchset.
>
> -- Sebastian
> ---
> arch/arm/mach-omap2/board-rx51-video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-video.c b/arch/arm/mach-omap2/board-rx51-video.c
> index 43a90c8..9cfebc5 100644
> --- a/arch/arm/mach-omap2/board-rx51-video.c
> +++ b/arch/arm/mach-omap2/board-rx51-video.c
> @@ -48,7 +48,7 @@ static struct omap_dss_board_info rx51_dss_board_info = {
>
> static int __init rx51_video_init(void)
> {
> - if (!machine_is_nokia_rx51() && !of_machine_is_compatible("nokia,omap3-n900"))
> + if (!machine_is_nokia_rx51())
> return 0;
>
> if (omap_mux_init_gpio(RX51_LCD_RESET_GPIO, OMAP_PIN_OUTPUT)) {
>
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot
2014-04-09 6:27 ` Tomi Valkeinen
@ 2014-04-18 22:43 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2014-04-18 22:43 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: Sebastian Reichel, linux-omap
* Tomi Valkeinen <tomi.valkeinen@ti.com> [140408 23:31]:
> On 08/04/14 23:51, Sebastian Reichel wrote:
> > Do not try to initialize display for DT boot, since omapdss
> > is now initialized via Device Tree. Without this patch the
> > display subsystem does not properly come up.
> >
> > Signed-off-by: Sebastian Reichel <sre@kernel.org>
> > ---
> > Hi,
> >
> > This patch should be added to 3.15-rc to make display initialization via DT
> > possible. Sorry for not noticing earlier, that this was missing in Tomi's
> > patchset.
> >
> > -- Sebastian
> > ---
> > arch/arm/mach-omap2/board-rx51-video.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-omap2/board-rx51-video.c b/arch/arm/mach-omap2/board-rx51-video.c
> > index 43a90c8..9cfebc5 100644
> > --- a/arch/arm/mach-omap2/board-rx51-video.c
> > +++ b/arch/arm/mach-omap2/board-rx51-video.c
> > @@ -48,7 +48,7 @@ static struct omap_dss_board_info rx51_dss_board_info = {
> >
> > static int __init rx51_video_init(void)
> > {
> > - if (!machine_is_nokia_rx51() && !of_machine_is_compatible("nokia,omap3-n900"))
> > + if (!machine_is_nokia_rx51())
> > return 0;
> >
> > if (omap_mux_init_gpio(RX51_LCD_RESET_GPIO, OMAP_PIN_OUTPUT)) {
> >
>
> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Applying into omap-for-v3.15/fixes thanks.
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-04-18 22:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-08 20:51 [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot Sebastian Reichel
2014-04-08 21:40 ` Aaro Koskinen
2014-04-08 22:23 ` Tony Lindgren
2014-04-08 23:09 ` Aaro Koskinen
2014-04-09 6:27 ` Tomi Valkeinen
2014-04-18 22:43 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).