From: Robert Baldyga <r.baldyga@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net, myungjoo.ham@samsung.com, cw00.choi@samsung.com,
dbaryshkov@gmail.com, dwmw2@infradead.org, balbi@ti.com,
gregkh@linuxfoundation.org, grant.likely@linaro.org,
ldewangan@nvidia.com, kishon@ti.com, gg@slimlogic.co.uk,
anton@enomsg.org, jonghwa3.lee@samsung.com, rongjun.ying@csr.com,
linux@roeck-us.net, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, aaro.koskinen@iki.fi,
m.szyprowski@samsung.com, t.figa@samsung.com,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v2 01/13] Documentation: add extcon devicetree bindings
Date: Fri, 25 Apr 2014 15:19:59 +0200 [thread overview]
Message-ID: <535A60FF.4000806@samsung.com> (raw)
In-Reply-To: <20140422195117.GG12304@sirena.org.uk>
On 04/22/2014 09:51 PM, Mark Brown wrote:
> On Mon, Apr 14, 2014 at 01:46:12PM +0200, Robert Baldyga wrote:
>
> That's quite some CC list you've got there, and the mail seems a bit
> corrupted too (it confused my MUA).
>
>> This patch adds extcon devicetree bindings. Documentation describes in general
>> client and provider bindings, and contains detailed desctiprion of bindings
>> for each extcon provider.
>>
>> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
>> ---
>> .../devicetree/bindings/extcon/extcon-adc-jack.txt | 60 +++++++++++++++++++
>> .../devicetree/bindings/extcon/extcon-arizona.txt | 47 +++++++++++++++
>> .../devicetree/bindings/extcon/extcon-bindings.txt | 36 +++++++++++
>> .../devicetree/bindings/extcon/extcon-gpio.txt | 63 ++++++++++++++++++++
>> .../devicetree/bindings/extcon/extcon-max14577.txt | 49 +++++++++++++++
>> .../devicetree/bindings/extcon/extcon-max77693.txt | 56 +++++++++++++++++
>> .../devicetree/bindings/extcon/extcon-max8997.txt | 49 +++++++++++++++
>> .../devicetree/bindings/extcon/extcon-palmas.txt | 37 ++++++++++--
>
> This is creating device tree bindings for MFD components as devices when
> those MFD components aren't well isolated from the rest of the device.
> If we need to add extcon bindings the device should have the flexibility
> to decide where to add the properties, and really things should be set
> up so there's less duplication in the documentation.
Those components has their own addresses on i2c bus, so they are,
technically, separate devices, and they can (should?) be described by
separate nodes. And I think it doesn't matter if they are grouped in one
chip.
However, it's easy to change it (give mfd master driver node to extcon),
and we can have extcon device defined without additional node, and then
parent node is an extcon node.
Best regards
Robert Baldyga
Samsung R&D Institute Poland
>
>> +The following is the list of cables detected by the controller. Each
>> +cable is assigned an identifier and client nodes use this identifies
>> +to specify the cable which they are interested in.
>> +
>> + Cable ID
>> + ----------------------------
>> +
>> + Mechanical 0
>> + Microphone 1
>> + Headphone 2
>> + Line-out 3
>> +
>> +Example 1: An example of a extcon controller node is listed below.
>> +
>> + extcon: arizona-extcon {
>
> The above doesn't entirely reflect what the hardware is capable of doing
> - it reflects the default software configuration for the device but it's
> got a wider feature set.
>
next prev parent reply other threads:[~2014-04-25 13:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 11:46 [PATCH v2 00/13] extcon: major rework Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 01/13] Documentation: add extcon devicetree bindings Robert Baldyga
2014-04-22 19:51 ` Mark Brown
2014-04-25 13:19 ` Robert Baldyga [this message]
2014-04-25 14:11 ` Mark Brown
2014-04-14 11:46 ` [PATCH v2 02/13] Documentation: update charger-manager " Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 03/13] extcon: extcon-class: remove extcon_set_cable_state() function Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 04/13] extcon: extcon-class: match extcon device by devicetree node Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 05/13] extcon: extcon-class: improve extcon client API Robert Baldyga
2014-04-19 10:52 ` Aaro Koskinen
[not found] ` <20140419105225.GB976-xqjnvvOjuzxi8rthE/p55WsfGuYhQEVp@public.gmane.org>
2014-04-22 6:21 ` Robert Baldyga
2014-04-22 14:51 ` Felipe Balbi
2014-04-22 15:03 ` Aaro Koskinen
2014-04-23 7:33 ` Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 06/13] extcon: extcon-class: remove unused functions Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 07/13] extcon: extcon-class: improve get_cable_state_()/set_cable_state_() functions Robert Baldyga
[not found] ` <1397475984-28001-1-git-send-email-r.baldyga-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-04-14 11:46 ` [PATCH v2 08/13] extcon: extcon-class: simplify extcon_updata_state() function Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 10/13] extcon: extcon-gpio: add devicetree support Robert Baldyga
2014-04-23 20:00 ` [PATCH v2 00/13] extcon: major rework Aaro Koskinen
2014-04-14 11:46 ` [PATCH v2 09/13] extcon: extcon-class: move example to Documentation Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 11/13] extcon: extcon-adc-jack: add devicetree support Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 12/13] extcon: extcon-max8997: check if pdata exists Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 13/13] extcon: extcon-max77693: " Robert Baldyga
2014-04-24 19:52 ` [PATCH v2 00/13] extcon: major rework Greg KH
2014-04-28 9:34 ` Robert Baldyga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535A60FF.4000806@samsung.com \
--to=r.baldyga@samsung.com \
--cc=aaro.koskinen@iki.fi \
--cc=anton@enomsg.org \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jonghwa3.lee@samsung.com \
--cc=kishon@ti.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=rongjun.ying@csr.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).