From: Roger Quadros <rogerq@ti.com>
To: Paul Walmsley <paul@pwsan.com>, tony@atomide.com
Cc: rnayak@ti.com, kishon@ti.com, george.cherian@ti.com,
balbi@ti.com, balajitk@ti.com, nsekhar@ti.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] ARM: DRA7: hwmod: Add OCP2SCP3 module
Date: Fri, 4 Jul 2014 12:49:53 +0300 [thread overview]
Message-ID: <53B678C1.4000807@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407031948110.1515@utopia.booyaka.com>
Hi Paul & Tony,
On 07/03/2014 10:48 PM, Paul Walmsley wrote:
> On Thu, 3 Jul 2014, Roger Quadros wrote:
>
>> This module is needed for the SATA and PCIe PHYs.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> Reviewed-by: Rajendra Nayak <rnayak@ti.com>
>> Tested-by: Sekhar Nori <nsekhar@ti.com>>
>
> This looks like adding support for a new device, so, after
> discussing with Tony, queuing for v3.17.
We should treat it as missing device (bug) rather than new device (feature) as the corresponding device tree node is already present.
Without this patch we get the following message in kernel boot log
[ 0.261680] platform 4a090000.ocp2scp: Cannot lookup hwmod 'ocp2scp3'
I would consider this patch as a fix rather than a new feature.
cheers,
-roger
next prev parent reply other threads:[~2014-07-04 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 11:01 [PATCH v2 0/3] OMAP: dra7: hwmod: Fixes for 3.16 Roger Quadros
2014-07-03 11:01 ` [PATCH v2 1/3] ARM: DRA7: hwmod: Add OCP2SCP3 module Roger Quadros
2014-07-03 19:48 ` Paul Walmsley
2014-07-04 9:49 ` Roger Quadros [this message]
2014-07-06 0:23 ` Paul Walmsley
2014-07-07 8:44 ` Roger Quadros
2014-07-03 11:01 ` [PATCH v2 2/3] ARM: DRA7: hwmod: Fixup SATA hwmod Roger Quadros
2014-07-03 19:47 ` Paul Walmsley
2014-07-03 11:01 ` [PATCH v2 3/3] ARM: DRA7: hwmod: Add SYSCONFIG for usb_otg_ss Roger Quadros
2014-07-03 19:48 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B678C1.4000807@ti.com \
--to=rogerq@ti.com \
--cc=balajitk@ti.com \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).