linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: kishon@ti.com, balbi@ti.com, nsekhar@ti.com, nm@ti.com,
	george.cherian@ti.com, sergei.shtylyov@cogentembedded.com,
	linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, Rajendra Nayak <rnayak@ti.com>,
	Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH v2 1/6] ARM: dts: dra7-evm: Make VDDA_1V8_PHY supply always on
Date: Mon, 7 Jul 2014 11:34:18 +0300	[thread overview]
Message-ID: <53BA5B8A.5010805@ti.com> (raw)
In-Reply-To: <20140707082922.GI28884@atomide.com>

Hi Tony,

On 07/07/2014 11:29 AM, Tony Lindgren wrote:
> * Roger Quadros <rogerq@ti.com> [140704 02:57]:
>> After clarification from the hardware team it was found that
>> this 1.8V PHY supply can't be switched OFF when SoC is Active.
>>
>> Since the PHY IPs don't contain isolation logic built in the design to
>> allow the power rail to be switched off, there is a very high risk
>> of IP reliability and additional leakage paths which can result in
>> additional power consumption.
>>
>> The only scenario where this rail can be switched off is part of Power on
>> reset sequencing, but it needs to be kept always-on during operation.
>>
>> This patch is required for proper functionality of USB, SATA
>> and PCIe on DRA7-evm.
>>
>> CC: Rajendra Nayak <rnayak@ti.com>
>> CC: Tero Kristo <t-kristo@ti.com>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
> 
> Best that you queue this with the series:

This patch doesn't have any dependency with the others and we're not even sure if
this series will hit 3.16.

But this 1V8 regulator _is_ required for normal operation of the SoC, whether the
PHYs are in use or not.

Can you please queue just this patch for SoC fixes for 3.16? Thanks.

cheers,
-roger

> 
> Acked-by: Tony Lindgren <tony@atomide.com>
> 
>> ---
>>  arch/arm/boot/dts/dra7-evm.dts | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
>> index 4adc280..8308954 100644
>> --- a/arch/arm/boot/dts/dra7-evm.dts
>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>> @@ -240,6 +240,7 @@
>>  					regulator-name = "ldo3";
>>  					regulator-min-microvolt = <1800000>;
>>  					regulator-max-microvolt = <1800000>;
>> +					regulator-always-on;
>>  					regulator-boot-on;
>>  				};
>>  
>> -- 
>> 1.8.3.2
>>


  reply	other threads:[~2014-07-07  8:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04  9:55 [PATCH v2 0/6] omap: phy: dra7-evm PHY fixes for 3.16 Roger Quadros
2014-07-04  9:55 ` [PATCH v2 1/6] ARM: dts: dra7-evm: Make VDDA_1V8_PHY supply always on Roger Quadros
     [not found]   ` <1404467748-12154-2-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-07-07  8:29     ` Tony Lindgren
2014-07-07  8:34       ` Roger Quadros [this message]
2014-07-07  8:44         ` Tony Lindgren
2014-07-04  9:55 ` [PATCH v2 2/6] phy: core: Fix error path in phy_create() Roger Quadros
2014-07-04  9:55 ` [PATCH v2 3/6] phy: core: Support regulator supply for PHY power Roger Quadros
2014-07-04  9:55 ` [PATCH v2 4/6] phy: core: Add phy-supply to DT binding documentation Roger Quadros
2014-07-04  9:55 ` [PATCH v2 5/6] phy: omap-usb2: Balance pm_runtime_enable() on probe failure and remove Roger Quadros
2014-07-04  9:55 ` [PATCH v2 6/6] ARM: dts: dra7-evm: Add regulator information to USB2 PHYs Roger Quadros
2014-07-07  8:29   ` Tony Lindgren
  -- strict thread matches above, loose matches on Subject: below --
2014-07-02 12:03 [PATCH 0/6] omap: phy: dra7-evm PHY fixes for 3.16 Roger Quadros
2014-07-02 12:03 ` [PATCH 1/6] ARM: dts: dra7-evm: Make VDDA_1V8_PHY supply always on Roger Quadros
2014-07-03  9:40   ` [PATCH v2 " Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BA5B8A.5010805@ti.com \
    --to=rogerq@ti.com \
    --cc=balbi@ti.com \
    --cc=george.cherian@ti.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=nsekhar@ti.com \
    --cc=rnayak@ti.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).