From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH] ASoC: omap-hdmi: Use devm_snd_soc_register_component Date: Mon, 7 Jul 2014 12:29:47 +0300 Message-ID: <53BA688B.3080901@ti.com> References: <1404629383-3225-1-git-send-email-badarkhe.manish@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:40191 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752461AbaGGJ3w (ORCPT ); Mon, 7 Jul 2014 05:29:52 -0400 In-Reply-To: <1404629383-3225-1-git-send-email-badarkhe.manish@gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Manish Badarkhe , linux-omap@vger.kernel.org, alsa-devel@alsa-project.org Cc: broonie@kernel.org On 07/06/2014 09:49 AM, Manish Badarkhe wrote: > Replaced snd_soc_register_component with its devres equivalent, > devm_snd_soc_register_component. >=20 > Signed-off-by: Manish Badarkhe > --- > :100644 100644 eb9c392... 1dc95b5... M sound/soc/omap/omap-hdmi.c > sound/soc/omap/omap-hdmi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/sound/soc/omap/omap-hdmi.c b/sound/soc/omap/omap-hdmi.c > index eb9c392..1dc95b5 100644 > --- a/sound/soc/omap/omap-hdmi.c > +++ b/sound/soc/omap/omap-hdmi.c > @@ -322,7 +322,7 @@ static int omap_hdmi_probe(struct platform_device= *pdev) > } > =20 > dev_set_drvdata(&pdev->dev, hdmi_data); > - ret =3D snd_soc_register_component(&pdev->dev, &omap_hdmi_component= , > + ret =3D devm_snd_soc_register_component(&pdev->dev, &omap_hdmi_comp= onent, > &omap_hdmi_dai, 1); As with the omap-mcbsp: Can you align the parameters as well? > =20 > if (ret) > @@ -335,8 +335,6 @@ static int omap_hdmi_remove(struct platform_devic= e *pdev) > { > struct hdmi_priv *hdmi_data =3D dev_get_drvdata(&pdev->dev); > =20 > - snd_soc_unregister_component(&pdev->dev); > - > if (hdmi_data =3D=3D NULL) { > dev_err(&pdev->dev, "cannot obtain HDMi data\n"); > return -ENODEV; >=20 --=20 P=E9ter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html