* [PATCH] ASoC: omap-hdmi: Use devm_snd_soc_register_component
@ 2014-07-06 6:49 Manish Badarkhe
2014-07-07 9:29 ` Peter Ujfalusi
0 siblings, 1 reply; 3+ messages in thread
From: Manish Badarkhe @ 2014-07-06 6:49 UTC (permalink / raw)
To: linux-omap, alsa-devel; +Cc: broonie, peter.ujfalusi, badarkhe.manish
Replaced snd_soc_register_component with its devres equivalent,
devm_snd_soc_register_component.
Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com>
---
:100644 100644 eb9c392... 1dc95b5... M sound/soc/omap/omap-hdmi.c
sound/soc/omap/omap-hdmi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/soc/omap/omap-hdmi.c b/sound/soc/omap/omap-hdmi.c
index eb9c392..1dc95b5 100644
--- a/sound/soc/omap/omap-hdmi.c
+++ b/sound/soc/omap/omap-hdmi.c
@@ -322,7 +322,7 @@ static int omap_hdmi_probe(struct platform_device *pdev)
}
dev_set_drvdata(&pdev->dev, hdmi_data);
- ret = snd_soc_register_component(&pdev->dev, &omap_hdmi_component,
+ ret = devm_snd_soc_register_component(&pdev->dev, &omap_hdmi_component,
&omap_hdmi_dai, 1);
if (ret)
@@ -335,8 +335,6 @@ static int omap_hdmi_remove(struct platform_device *pdev)
{
struct hdmi_priv *hdmi_data = dev_get_drvdata(&pdev->dev);
- snd_soc_unregister_component(&pdev->dev);
-
if (hdmi_data == NULL) {
dev_err(&pdev->dev, "cannot obtain HDMi data\n");
return -ENODEV;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: omap-hdmi: Use devm_snd_soc_register_component
2014-07-06 6:49 [PATCH] ASoC: omap-hdmi: Use devm_snd_soc_register_component Manish Badarkhe
@ 2014-07-07 9:29 ` Peter Ujfalusi
2014-07-08 11:47 ` Manish Badarkhe
0 siblings, 1 reply; 3+ messages in thread
From: Peter Ujfalusi @ 2014-07-07 9:29 UTC (permalink / raw)
To: Manish Badarkhe, linux-omap, alsa-devel; +Cc: broonie
On 07/06/2014 09:49 AM, Manish Badarkhe wrote:
> Replaced snd_soc_register_component with its devres equivalent,
> devm_snd_soc_register_component.
>
> Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com>
> ---
> :100644 100644 eb9c392... 1dc95b5... M sound/soc/omap/omap-hdmi.c
> sound/soc/omap/omap-hdmi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/omap/omap-hdmi.c b/sound/soc/omap/omap-hdmi.c
> index eb9c392..1dc95b5 100644
> --- a/sound/soc/omap/omap-hdmi.c
> +++ b/sound/soc/omap/omap-hdmi.c
> @@ -322,7 +322,7 @@ static int omap_hdmi_probe(struct platform_device *pdev)
> }
>
> dev_set_drvdata(&pdev->dev, hdmi_data);
> - ret = snd_soc_register_component(&pdev->dev, &omap_hdmi_component,
> + ret = devm_snd_soc_register_component(&pdev->dev, &omap_hdmi_component,
> &omap_hdmi_dai, 1);
As with the omap-mcbsp:
Can you align the parameters as well?
>
> if (ret)
> @@ -335,8 +335,6 @@ static int omap_hdmi_remove(struct platform_device *pdev)
> {
> struct hdmi_priv *hdmi_data = dev_get_drvdata(&pdev->dev);
>
> - snd_soc_unregister_component(&pdev->dev);
> -
> if (hdmi_data == NULL) {
> dev_err(&pdev->dev, "cannot obtain HDMi data\n");
> return -ENODEV;
>
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: omap-hdmi: Use devm_snd_soc_register_component
2014-07-07 9:29 ` Peter Ujfalusi
@ 2014-07-08 11:47 ` Manish Badarkhe
0 siblings, 0 replies; 3+ messages in thread
From: Manish Badarkhe @ 2014-07-08 11:47 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: linux-omap, alsa-devel, Mark Brown
Hi Peter,
On Mon, Jul 7, 2014 at 2:59 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> On 07/06/2014 09:49 AM, Manish Badarkhe wrote:
>> Replaced snd_soc_register_component with its devres equivalent,
>> devm_snd_soc_register_component.
>>
>> Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com>
>> ---
>> :100644 100644 eb9c392... 1dc95b5... M sound/soc/omap/omap-hdmi.c
>> sound/soc/omap/omap-hdmi.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/sound/soc/omap/omap-hdmi.c b/sound/soc/omap/omap-hdmi.c
>> index eb9c392..1dc95b5 100644
>> --- a/sound/soc/omap/omap-hdmi.c
>> +++ b/sound/soc/omap/omap-hdmi.c
>> @@ -322,7 +322,7 @@ static int omap_hdmi_probe(struct platform_device *pdev)
>> }
>>
>> dev_set_drvdata(&pdev->dev, hdmi_data);
>> - ret = snd_soc_register_component(&pdev->dev, &omap_hdmi_component,
>> + ret = devm_snd_soc_register_component(&pdev->dev, &omap_hdmi_component,
>> &omap_hdmi_dai, 1);
>
> As with the omap-mcbsp:
> Can you align the parameters as well?
Sure, will do it and send next version.
Regards
Manish Badarkhe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-08 11:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-06 6:49 [PATCH] ASoC: omap-hdmi: Use devm_snd_soc_register_component Manish Badarkhe
2014-07-07 9:29 ` Peter Ujfalusi
2014-07-08 11:47 ` Manish Badarkhe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).