From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH] clk: ti: clk-7xx: Correct ABE DPLL configuration Date: Mon, 14 Jul 2014 13:10:28 +0300 Message-ID: <53C3AC94.5050904@ti.com> References: <1396446525-20302-1-git-send-email-peter.ujfalusi@ti.com> <533C1AC2.1000307@ti.com> <533CFFB3.9070201@ti.com> <5358D534.2070205@ti.com> <535927DF.90404@ti.com> <5368E604.4040107@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <5368E604.4040107@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Tero Kristo , Mike Turquette Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org On 05/06/2014 04:39 PM, Peter Ujfalusi wrote: >>> Tero: can I have your ack for this patch or do you have further con= cerns? >> >> Yea looks good to me, except for the fact that there is some work on= getting >> default rate/parent support through DT. I would like a comment from = Mike about >> the estimate when this can get in, and whether we should merge inter= mediate >> solutions still like this. >> >> Anyway, you can consider this patch acked by me, I'll let Mike to de= cide what >> to do with it though. >=20 > Do you have anything against this patch? Since right now there is no = other > ways to fix the ABE DPLL for dra7 it would be great if we could have = this in > till we have the final solution. Also I'd like to point out that the = original > frequency the ABE DPLL was not correct and renders the audio to be no= t usable > on the platform. Mike: can we have this patch still pushed for 3.16? I can resend it rig= ht away if you lost the original patch. Thanks, P=E9ter >=20 >>>> >>>>> >>>>> -Tero >>>>> >>>>>> >>>>>> Signed-off-by: Peter Ujfalusi >>>>>> --- >>>>>> drivers/clk/ti/clk-7xx.c | 7 ++++++- >>>>>> 1 file changed, 6 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c >>>>>> index f7e40734c819..19a55bf407dd 100644 >>>>>> --- a/drivers/clk/ti/clk-7xx.c >>>>>> +++ b/drivers/clk/ti/clk-7xx.c >>>>>> @@ -16,7 +16,7 @@ >>>>>> #include >>>>>> #include >>>>>> >>>>>> -#define DRA7_DPLL_ABE_DEFFREQ 361267200 >>>>>> +#define DRA7_DPLL_ABE_DEFFREQ 180633600 >>>>>> #define DRA7_DPLL_GMAC_DEFFREQ 1000000000 >>>>>> >>>>>> >>>>>> @@ -322,6 +322,11 @@ int __init dra7xx_dt_clk_init(void) >>>>>> if (rc) >>>>>> pr_err("%s: failed to configure ABE DPLL!\n", __func_= _); >>>>>> >>>>>> + dpll_ck =3D clk_get_sys(NULL, "dpll_abe_m2x2_ck"); >>>>>> + rc =3D clk_set_rate(dpll_ck, DRA7_DPLL_ABE_DEFFREQ * 2); >>>>>> + if (rc) >>>>>> + pr_err("%s: failed to configure ABE DPLL m2x2!\n", __fu= nc__); >>>>>> + >>>>>> dpll_ck =3D clk_get_sys(NULL, "dpll_gmac_ck"); >>>>>> rc =3D clk_set_rate(dpll_ck, DRA7_DPLL_GMAC_DEFFREQ); >>>>>> if (rc) >>>>>> >>>>> >>>> >>>> >>> >> >=20 > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap"= in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >=20