From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH] ARM: OMAP: generic: add call to of_clk_init()
Date: Mon, 28 Jul 2014 14:46:00 +0300
Message-ID: <53D637F8.8080600@ti.com>
References: <1405162508-9835-1-git-send-email-zonque@gmail.com> <20140723085444.GC22006@atomide.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-omap-owner@vger.kernel.org>
Received: from arroyo.ext.ti.com ([192.94.94.40]:32797 "EHLO arroyo.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752577AbaG1Lov (ORCPT <rfc822;linux-omap@vger.kernel.org>);
	Mon, 28 Jul 2014 07:44:51 -0400
In-Reply-To: <20140723085444.GC22006@atomide.com>
Sender: linux-omap-owner@vger.kernel.org
List-Id: linux-omap@vger.kernel.org
To: Tony Lindgren <tony@atomide.com>, Daniel Mack <zonque@gmail.com>
Cc: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org

On 07/23/2014 11:54 AM, Tony Lindgren wrote:
> * Daniel Mack <zonque@gmail.com> [140712 03:57]:
>> This is needed to instanciate fixed clocks in the DT.
>
> Makes sense to me. Does this fix some regression or hang
> that's needed for the -rc series?
>
> Also would like to get an ack from Tero on this as the other
> clocks are initialized elsewhere.

NAK.

Fixed-clocks are already supported through DT clock init. Doing this 
from board-generic will result in duplicate init calls (out of which one 
will fail silently.)

What are you trying to accomplish with this patch anyway?

-Tero

>
> Regards,
>
> Tony
>
>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>> ---
>>   arch/arm/mach-omap2/board-generic.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
>> index 5606fa2..39f154a 100644
>> --- a/arch/arm/mach-omap2/board-generic.c
>> +++ b/arch/arm/mach-omap2/board-generic.c
>> @@ -15,6 +15,7 @@
>>   #include <linux/of_irq.h>
>>   #include <linux/of_platform.h>
>>   #include <linux/irqdomain.h>
>> +#include <linux/clk-provider.h>
>>
>>   #include <asm/mach/arch.h>
>>
>> @@ -33,6 +34,11 @@ static struct of_device_id omap_dt_match_table[] __initdata = {
>>   	{ }
>>   };
>>
>> +static struct of_device_id clk_match[] __initdata = {
>> +	{ .compatible = "fixed-clock", .data = of_fixed_clk_setup, },
>> +	{ }
>> +};
>> +
>>   static void __init omap_generic_init(void)
>>   {
>>   	omapdss_early_init_of();
>> @@ -40,6 +46,8 @@ static void __init omap_generic_init(void)
>>   	pdata_quirks_init(omap_dt_match_table);
>>
>>   	omapdss_init_of();
>> +
>> +	of_clk_init(clk_match);
>>   }
>>
>>   #ifdef CONFIG_SOC_OMAP2420
>> --
>> 1.9.3
>>